Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions run/helloworld/test/e2e_test_cleanup.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

steps:

- id: 'Delete image and service'
Expand Down
15 changes: 15 additions & 0 deletions run/helloworld/test/e2e_test_setup.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
# Copyright 2026 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

steps:

- id: 'Build Container Image'
Expand Down Expand Up @@ -25,6 +39,7 @@ steps:
./test/retry.sh "gcloud run deploy ${_SERVICE} \
--image gcr.io/${PROJECT_ID}/${_SERVICE}:${_VERSION} \
--no-allow-unauthenticated \
--ingress internal \
--region ${_REGION} \
--platform ${_PLATFORM} \
--set-env-vars NAME=${_NAME} \
Expand Down
2 changes: 1 addition & 1 deletion run/helloworld/test/system.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@
'--config ./test/e2e_test_cleanup.yaml ' +
`--substitutions _SERVICE=${SERVICE_NAME},_PLATFORM=${PLATFORM},_REGION=${REGION}`;
if (SAMPLE_VERSION) cleanUpCmd += `,_VERSION=${SAMPLE_VERSION}`;
if (SERVICE_ACCOUNT) cleanUpCmd += `,_SERVICE_ACCOUNT=${SERVICE_ACCOUNT}`;

Check failure on line 78 in run/helloworld/test/system.test.js

View workflow job for this annotation

GitHub Actions / lint

'cleanUpCmd' is assigned a value but never used

execSync(cleanUpCmd);
//execSync(cleanUpCmd);
});

it('Service uses the NAME override', async () => {
Expand Down
Loading