Skip to content

fix(healthcare): set responseType to JSON instead of Buffer in deleteFhirResource.js #4247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
angelcaamal wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −5
Open

fix(healthcare): set responseType to JSON instead of Buffer in deleteFhirResource.js #4247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb7bc5c
fix(healthcare): set responseType to JSON instead of Buffer
angelcaamal Mar 5, 2026
c876688
fix(healthcare): Fix test for delete resource
angelcaamal Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions healthcare/fhir/deleteFhirResource.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ const main = (
auth: new google.auth.GoogleAuth({
scopes: ['https://www.googleapis.com/auth/cloud-platform'],
}),
responseType: 'json',
});

const deleteFhirResource = async () => {
Expand All @@ -46,10 +47,14 @@ const main = (
// fails, the server returns a 200 OK HTTP status code. To check that the
// resource was successfully deleted, search for or get the resource and
// see if it exists.
await healthcare.projects.locations.datasets.fhirStores.fhir.delete(
request
);
console.log('Deleted FHIR resource');
try {
await healthcare.projects.locations.datasets.fhirStores.fhir.delete(
request
);
console.log(`Deleted FHIR resource: ${resourceId}`);
} catch (error) {
console.error('Error deleting FHIR resource:', error.message || error);
}
};

deleteFhirResource();
Expand Down
5 changes: 4 additions & 1 deletion healthcare/fhir/system-test/fhir_resources.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,10 @@ it('should delete a FHIR resource', () => {
`node deleteFhirResource.js ${projectId} ${cloudRegion} ${datasetId} ${fhirStoreId} ${resourceType} ${resourceId}`,
{cwd}
);
assert.strictEqual(new RegExp('Deleted FHIR resource').test(output), true);
assert.strictEqual(
new RegExp(`Deleted FHIR resource: ${resourceId}`).test(output),
true
);

// Clean up
execSync(
Expand Down
Loading