Support empty spec sub-blocks for GKE Hub Feature (workloadidentity /… - #18834
Open
cowsking wants to merge 1 commit into
Open
Support empty spec sub-blocks for GKE Hub Feature (workloadidentity /…#18834cowsking wants to merge 1 commit into
cowsking wants to merge 1 commit into
Conversation
… fleetobservability)
modular-magician
added
the
awaiting-approval
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When users configure features that require empty sub-blocks (such as
spec { workloadidentity {} }orspec { fleetobservability {} }), the generated expander previously dropped empty maps due to!IsEmptyValue()checks. This caused the GKE Hub API to reject the request with400: MissingFieldError for field spec: should be set.This PR adds
send_empty_value: trueto theworkloadidentityandfleetobservabilityNestedObjectdefinitions underspecinFeature.yamlso that empty spec objects are preserved in the payload.Closes hashicorp/terraform-provider-google#29014