Skip to content

oracledatabase: fix TestAccOracleDatabaseDbServers_basic - #18832

Open
SirGitsalot wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
SirGitsalot:fix-oracledatabase-db-servers-basic
Open

oracledatabase: fix TestAccOracleDatabaseDbServers_basic#18832
SirGitsalot wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
SirGitsalot:fix-oracledatabase-db-servers-basic

Conversation

@SirGitsalot

@SirGitsalot SirGitsalot commented Aug 28, 2026

Copy link
Copy Markdown
Member

Fixes nightly acceptance test failure for TestAccOracleDatabaseDbServers_basic.

Root Cause & Fix

  1. Incorrect Template Variable in ID Construction:
    DataSourceOracleDatabaseDbServersRead in data_source_oracle_database_db_servers.go constructed the resource ID using projects/{{project}}/locations/{{location}}/cloudExadataInfrastructures/{{cloud_exadata_infrastructure_id}}/dbServers.
    The schema field name is cloud_exadata_infrastructure (not cloud_exadata_infrastructure_id). This mismatch caused variable replacement to fail when setting the resource ID.

  2. Persist Project in ResourceData:
    Added d.Set("project", project) so that the resolved project is properly stored in schema.ResourceData, ensuring tpgresource.ReplaceVars and subsequent state checks can access the project attribute.

@modular-magician

modular-magician commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b89a7f9:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 5 insertions(+), 1 deletion(-)
google-beta provider View Diff 1 file changed, 5 insertions(+), 1 deletion(-)

Test report

Analytics

Total Tests Passed Skipped Affected
50 48 2 0
Affected Service Packages
  • oracledatabase

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@SirGitsalot VCR tests complete for b89a7f9!

@SirGitsalot

Copy link
Copy Markdown
Member Author

@modular-magician reassign-reviewer

@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from slevenick August 28, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants