databasemigrationservice: fix display_name in test configs

[SirGitsalot]

Fix Database Migration Service tests, samples, and deletion issues:

1. display_name validation: Replace invalid underscore (_) characters in display_name fields with hyphens (-) across test configurations and sample templates, satisfying API validation (^[a-zA-Z][a-zA-Z0-9 -]*$) and resolving "The field display_name can't contain special characters." errors.
2. Object filtering type: Update database_migration_service_migration_job_postgres_to_postgres_objects sample template to use database-level filtering (type = "DATABASE") instead of table-level filtering, resolving "Schema and table level filtering is not supported." errors.
3. Private connection deletion retry: Add IsDatabaseMigrationServiceOperationTimeoutError retry predicate to google_database_migration_service_private_connection to handle and retry when the backend operation returns "Operation timed out." during deletion.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c244c99:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	8 files changed, 53 insertions(+), 53 deletions(-)
google-beta provider	View Diff	8 files changed, 53 insertions(+), 53 deletions(-)
Open in Cloud Shell	View Diff	13 files changed, 22 insertions(+), 22 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
17	2	0	15

Affected Service Packages

• databasemigrationservice

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydb
• TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample
• TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileExistingAlloydbExample
• TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileExistingMysqlExample
• TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileExistingPostgresExample
• TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresExample
• TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresNoSslExample
• TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresRequiredSslExample
• TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobMysqlToMysqlExample
• TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobPostgresToAlloydbExample
• TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobPostgresToPostgresExample
• TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobPostgresToPostgresObjectsExample
• TestAccDatabaseMigrationServiceMigrationJob_update
• TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample
• TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionPscExample

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileAlloydb
✅ Log	✅	TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample
✅ Log	✅	TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileExistingAlloydbExample
✅ Log	✅	TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileExistingMysqlExample
✅ Log	✅	TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileExistingPostgresExample
✅ Log	✅	TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresExample
✅ Log	✅	TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresNoSslExample
✅ Log	✅	TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfilePostgresRequiredSslExample
✅ Log	✅	TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobMysqlToMysqlExample
✅ Log	✅	TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobPostgresToAlloydbExample
✅ Log	✅	TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobPostgresToPostgresExample
✅ Log	✅	TestAccDatabaseMigrationServiceMigrationJob_update
❌ Error · Log	-	TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobPostgresToPostgresObjectsExample
❌ Error · Log	-	TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample
❌ Error · Log	-	TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionPscExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@SirGitsalot VCR tests complete for c244c99!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0c63539:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	8 files changed, 55 insertions(+), 59 deletions(-)
google-beta provider	View Diff	8 files changed, 55 insertions(+), 59 deletions(-)
Open in Cloud Shell	View Diff	13 files changed, 23 insertions(+), 25 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
17	14	0	3

Affected Service Packages

• databasemigrationservice

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobPostgresToPostgresObjectsExample
• TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample
• TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionPscExample

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccDatabaseMigrationServiceMigrationJob_databaseMigrationServiceMigrationJobPostgresToPostgresObjectsExample
❌ Error · Log	-	TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample
❌ Error · Log	-	TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionPscExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@SirGitsalot VCR tests complete for 0c63539!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2e03cce:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	11 files changed, 110 insertions(+), 86 deletions(-)
google-beta provider	View Diff	11 files changed, 110 insertions(+), 86 deletions(-)
terraform-google-conversion	View Diff	1 file changed, 13 insertions(+)
Open in Cloud Shell	View Diff	13 files changed, 23 insertions(+), 25 deletions(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
6933	6218	698	17

Affected Service Packages

• All service packages are affected

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeInstanceFromMachineImage_diffProject
• TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
• TestAccContainerCluster_autopilot_privileged_admission
• TestAccContainerCluster_dataplaneOptimizationMode
• TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
• TestAccContainerCluster_withSoleTenantGroup
• TestAccContainerNodePool_withHugepageConfig
• TestAccContainerNodePool_withSoleTenantConfig
• TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample
• TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionPscExample
• TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
• TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
• TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
• TestAccProjectIamMemberRemove_memberInMultipleBindings
• TestAccPubsubSubscription_pubsubSubscriptionTagsExample
• TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
• TestAccVertexAISemanticGovernancePolicyEngine_basic

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccContainerCluster_withNodeConfigKubeletConfigSettingsInNodePool
✅ Log	✅	TestAccContainerCluster_withSoleTenantGroup
✅ Log	✅	TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log	-	TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log	-	TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log	-	TestAccContainerCluster_autopilot_privileged_admission
❌ Error · Log	-	TestAccContainerCluster_dataplaneOptimizationMode
❌ Error · Log	-	TestAccContainerNodePool_withHugepageConfig
❌ Error · Log	-	TestAccContainerNodePool_withSoleTenantConfig
❌ Error · Log	-	TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionExample
❌ Error · Log	-	TestAccDatabaseMigrationServicePrivateConnection_databaseMigrationServicePrivateConnectionPscExample
❌ Error · Log	-	TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log	-	TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log	-	TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log	-	TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log	-	TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
❌ Error · Log	-	TestAccVertexAISemanticGovernancePolicyEngine_basic

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@SirGitsalot VCR tests complete for 2e03cce!