compute: mark instance autoDelete updatable - #18822
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@googlebot rescan |
|
I have added the changelog and accepted the contribution agreement, but don't know how to get it to rescan. Given the rest of the checks passed I am going to mark this ready for review - please let me know if that's wrong I will be happy to fix :) |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1ebadbe: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @grandmadeb15, @ScottSuarez VCR tests complete for 1ebadbe! |
|
@googlebot rescan |
Corrects the MMv1 update metadata for
google_compute_instance.boot_disk.auto_deleteto match the existing handwritten in-place-update implementation. Adds acceptance-test plan checks confirming that changes continue to update the instance rather than replace it.