Skip to content

compute: mark instance autoDelete updatable - #18822

Open
grandmadeb15 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
grandmadeb15:compute-instance-autodelete-update
Open

compute: mark instance autoDelete updatable#18822
grandmadeb15 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
grandmadeb15:compute-instance-autodelete-update

Conversation

@grandmadeb15

@grandmadeb15 grandmadeb15 commented Aug 28, 2026

Copy link
Copy Markdown

Corrects the MMv1 update metadata for google_compute_instance.boot_disk.auto_delete to match the existing handwritten in-place-update implementation. Adds acceptance-test plan checks confirming that changes continue to update the instance rather than replace it.

release-note:none

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 28, 2026
@google-cla

google-cla Bot commented Aug 28, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@grandmadeb15

Copy link
Copy Markdown
Author

@googlebot rescan

@grandmadeb15

Copy link
Copy Markdown
Author

I have added the changelog and accepted the contribution agreement, but don't know how to get it to rescan. Given the rest of the checks passed I am going to mark this ready for review - please let me know if that's wrong I will be happy to fix :)

@grandmadeb15
grandmadeb15 marked this pull request as ready for review August 28, 2026 15:18
@github-actions
github-actions Bot requested a review from ScottSuarez August 28, 2026 15:18
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/compute-instances and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Aug 28, 2026
@modular-magician

modular-magician commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1ebadbe:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 10 insertions(+)
google-beta provider View Diff 1 file changed, 10 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
1559 1462 95 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@grandmadeb15, @ScottSuarez VCR tests complete for 1ebadbe!

@grandmadeb15

Copy link
Copy Markdown
Author

@googlebot rescan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants