Skip to content

cloudsecuritycompliance: add nested parameter_spec fields to google_cloud_security_compliance_cloud_control - #18808

Open
slevenick wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:mm-b-550549356
Open

cloudsecuritycompliance: add nested parameter_spec fields to google_cloud_security_compliance_cloud_control#18808
slevenick wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:mm-b-550549356

Conversation

@slevenick

Copy link
Copy Markdown
Contributor

Add nested parameter_spec fields to google_cloud_security_compliance_cloud_control.

reference: b/550549356

cloudsecuritycompliance: added `parameter_spec.sub_parameters.sub_parameters` and nested `oneof_value` fields to `google_cloud_security_compliance_cloud_control`

@modular-magician

modular-magician commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e350cb0:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 4651 insertions(+), 1553 deletions(-)
google-beta provider View Diff 4 files changed, 4651 insertions(+), 1553 deletions(-)
terraform-google-conversion View Diff 1 file changed, 1312 insertions(+), 115 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_security_compliance_cloud_control (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_security_compliance_cloud_control" "primary" {
  parameter_spec {
    default_value {
      oneof_value {
        parameter_value {
          oneof_value {
            parameter_value {
              bool_value   = # value needed
              number_value = # value needed
              string_list_value {
                values = # value needed
              }
            }
          }
        }
      }
    }
    sub_parameters {
      default_value {
        oneof_value {
          parameter_value {
            oneof_value {
              parameter_value {
                bool_value   = # value needed
                number_value = # value needed
                string_list_value {
                  values = # value needed
                }
              }
            }
          }
        }
      }
      sub_parameters {
        default_value {
          bool_value   = # value needed
          number_value = # value needed
          oneof_value {
            name = # value needed
            parameter_value {
              bool_value   = # value needed
              number_value = # value needed
              string_list_value {
                values = # value needed
              }
              string_value = # value needed
            }
          }
          string_list_value {
            values = # value needed
          }
        }
        substitution_rules {
          attribute_substitution_rule {
            attribute = # value needed
          }
          placeholder_substitution_rule {
            attribute = # value needed
          }
        }
        validation {
          allowed_values {
            values {
              bool_value   = # value needed
              number_value = # value needed
              oneof_value {
                name = # value needed
                parameter_value {
                  bool_value   = # value needed
                  number_value = # value needed
                  string_list_value {
                    values = # value needed
                  }
                  string_value = # value needed
                }
              }
              string_list_value {
                values = # value needed
              }
              string_value = # value needed
            }
          }
          int_range {
            max = # value needed
            min = # value needed
          }
          regexp_pattern {
            pattern = # value needed
          }
        }
      }
      validation {
        allowed_values {
          values {
            oneof_value {
              parameter_value {
                oneof_value {
                  parameter_value {
                    bool_value   = # value needed
                    number_value = # value needed
                    string_list_value {
                      values = # value needed
                    }
                  }
                }
              }
            }
          }
        }
      }
    }
    validation {
      allowed_values {
        values {
          oneof_value {
            parameter_value {
              oneof_value {
                parameter_value {
                  bool_value   = # value needed
                  number_value = # value needed
                  string_list_value {
                    values = # value needed
                  }
                }
              }
            }
          }
        }
      }
    }
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
17 16 0 1
Affected Service Packages
  • cloudsecuritycompliance

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccCloudSecurityComplianceCloudControl_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccCloudSecurityComplianceCloudControl_update

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for e350cb0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants