Skip to content

Ga on failed healthcheck#17998

Open
RooBarsic wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
RooBarsic:ga-on-failed-healthcheck
Open

Ga on failed healthcheck#17998
RooBarsic wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
RooBarsic:ga-on-failed-healthcheck

Conversation

@RooBarsic

Copy link
Copy Markdown
Contributor

This promotes Compute (R)IGM.InstanceLifecyclePolicy.OnFailedHealthCheck functionalities in V1.

All the IGM and RIGM tests have been ran and pass.

fixes hashicorp/terraform-provider-google#27886

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `instance_lifecycle_policy.on_failed_health_check` field in resources `google_compute_instance_group_manager` and `google_compute_region_instance_group_manager` (v1)

@github-actions github-actions Bot requested a review from roaks3 June 17, 2026 22:47
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit fbfe50b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 8 files changed, 38 insertions(+), 10 deletions(-)
google-beta provider View Diff 4 files changed, 7 insertions(+), 13 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1483 1390 93 0
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@RooBarsic, @roaks3, @chayankumar999 VCR tests complete for fbfe50b!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Promote to V1 InstanceLifecyclePolicy.OnFailedHealthCheck for compute_(region_)instance_group_managers

2 participants