list/MMv1: unionize allProps within listScope to include url_param_only values#17985
Open
BBBmau wants to merge 1 commit into
Open
list/MMv1: unionize allProps within listScope to include url_param_only values#17985BBBmau wants to merge 1 commit into
list/MMv1: unionize allProps within listScope to include url_param_only values#17985BBBmau wants to merge 1 commit into
Conversation
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit dc0c682: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
melinath
reviewed
Jun 17, 2026
melinath
left a comment
Member
There was a problem hiding this comment.
Just to make sure I understand this correctly - what exactly is a ListScope? It looks like IdentityProperties is specifically related to Resource Identity, which is also a core part of list resources, but is different from list scope?
To put this another way: is this a problem with ListScopeProperties or a problem with IdentityProperties? If a particular field is in base_url but not in import_format, wouldn't that need to still be part of the resource identity?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We run into a case found in
kms: add list resource forcrypto_key_version#17984where extracting from just
import_formatwas not enough due to the resulting list_resource_generation being empty in it'sCryptoKeyVersionTypeModel.List scope detection previously only used identity/import fields, so required URL-only scope values (like crypto_key) were missed.
This change includes all relevant properties when deriving list scope, deduplicates matches, and adds a regression test for the CryptoKeyVersion pattern.
Needed to merge #17984 as it becomes passing afterwards
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.