Skip to content

Terraform Support for Chronicle DataExport#17973

Open
avbanerjee wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
avbanerjee:chronicle-dataexport-avijitbanerjee
Open

Terraform Support for Chronicle DataExport#17973
avbanerjee wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
avbanerjee:chronicle-dataexport-avijitbanerjee

Conversation

@avbanerjee

@avbanerjee avbanerjee commented Jun 16, 2026

Copy link
Copy Markdown

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

chronicle: added `google_chronicle_data_export` resource (beta)

@github-actions github-actions Bot requested a review from melinath June 16, 2026 08:29
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

This comment was marked as outdated.

@avbanerjee avbanerjee force-pushed the chronicle-dataexport-avijitbanerjee branch from 4d5297e to dbddf9e Compare June 16, 2026 09:29
@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@avbanerjee avbanerjee changed the title Chronicle dataexport avijitbanerjee Terraform Support for Chronicle DataExport Jun 16, 2026
@avbanerjee avbanerjee force-pushed the chronicle-dataexport-avijitbanerjee branch from f637ba7 to 4a5d938 Compare June 16, 2026 10:08
@modular-magician

This comment was marked as outdated.

@avbanerjee avbanerjee force-pushed the chronicle-dataexport-avijitbanerjee branch from 4a5d938 to 2870bc1 Compare June 16, 2026 11:05
@modular-magician

modular-magician commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2870bc1:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 273 insertions(+), 1 deletion(-)
google-beta provider View Diff 5 files changed, 1282 insertions(+), 1 deletion(-)
terraform-google-conversion View Diff 1 file changed, 211 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
73 70 1 2
Affected Service Packages
  • bigqueryanalyticshub
  • chronicle

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccChronicleDataExport_chronicleDataExportBasicExample
  • TestAccChronicleDataExport_chronicleDataExportFullExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccChronicleDataExport_chronicleDataExportBasicExample
❌ Error · Log - TestAccChronicleDataExport_chronicleDataExportFullExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@avbanerjee, @melinath, @sachinpro, @ankitgoyal0301 VCR tests complete for 2870bc1!

@melinath melinath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall this looks reasonable; just some small changes for the descriptions.

And of course the tests need to pass, but I can't tell what the problem is from the API error.

properties:
- name: name
type: String
description: Output only. The resource name of the data export.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here & elsewhere: "Output only", "Required", and "Optional" will be autogenerated based on the settings for the field & should be omitted from the descriptions so they're not duplicated. See generated output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants