Terraform Support for Chronicle DataExport#17973
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This comment was marked as outdated.
This comment was marked as outdated.
4d5297e to
dbddf9e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
f637ba7 to
4a5d938
Compare
This comment was marked as outdated.
This comment was marked as outdated.
4a5d938 to
2870bc1
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2870bc1: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @avbanerjee, @melinath, @sachinpro, @ankitgoyal0301 VCR tests complete for 2870bc1! |
melinath
left a comment
There was a problem hiding this comment.
overall this looks reasonable; just some small changes for the descriptions.
And of course the tests need to pass, but I can't tell what the problem is from the API error.
| properties: | ||
| - name: name | ||
| type: String | ||
| description: Output only. The resource name of the data export. |
There was a problem hiding this comment.
Here & elsewhere: "Output only", "Required", and "Optional" will be autogenerated based on the settings for the field & should be omitted from the descriptions so they're not duplicated. See generated output.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.