Fix custom metrics adapter OpenAPI v3 definitions#1195
Open
bruno-espino wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
OpenAPIV3Configwith the same generated definitions used for OpenAPI v2.Observed from adapter logs with
gcr.io/gke-release/custom-metrics-stackdriver-adapter:v0.16.7-gke.0after the API aggregation layer queried OpenAPI v3:Local repro: leave
OpenAPIV3Confignil, callcmd.Config()beforeWithCustomMetrics/WithExternalMetrics, then build v3 definitions for one of the model names above.custom-metrics-apiserverinitializes a default v3 config at that point, before metric providers are registered, so the custom/external metric definitions are missing.#1174 added the name mapping for
OpenAPIConfig, butOpenAPIV3Configis still nil. This wires v3 to the same generated definitions and adds a regression test for the exact missing model names.