chore: remove redundant region tags from GcsEvent POJOs#10275
Open
Kef131 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the functions_helloworld_gcs_event region tags from the GcsEvent.java files across multiple Cloud Functions samples, including hello-gcs, imagemagick, and ocr-process-image. There are no review comments, and I have no feedback to provide on these changes.
|
Here is the summary of changes. You are about to delete 2 region tags.
This comment is generated by snippet-bot.
|
e6b5745 to
39c2af5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes b/385748009
Removes the duplicate
functions_helloworld_gcs_eventregion tags from the GcsEvent POJO files in bothfunctions/imagemagickandfunctions/ocr/ocr-process-imageThe file
GcsEvent.javais used in the implementation ofImageMagick.java. However, its region tag is currently duplicated across multiple locations on repository.Affected File Paths
The duplicate region tags are found in the following
GcsEvent.javafiles:functions/helloworld/hello-gcs/src/main/java/functions/eventpojos/GcsEvent.javafunctions/ocr/ocr-process-image/src/main/java/functions/eventpojos/GcsEvent.javafunctions/imagemagick/src/main/java/functions/eventpojos/GcsEvent.javain the case of
functions/hello-gsc, it keeps a metadata reference onfunctions.txtpbwhich trigger an error if is removed.Context and References
ImageMagick.java: This file is not orphaned. Its region tags (functions_imagemagick_setup,functions_imagemagick_analyze, andfunctions_imagemagick_blur) are actively referenced by the 1st Generation ImageMagick Tutorial (imagemagick-1st-gen.md).Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequired (Integration tests require configured GCS buckets and Vision API credentials in local testing. The codebase structure remains intact and CI will execute them with target credentials)mvn -P lint checkstyle:checkrequired (Both modified projects ran and passed with 0 checkstyle violations)mvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only (No code logic was added or changed)