Fix no data bug / Replace hardcoded requester filter with dropdown - #545
Open
ikenwan-dev wants to merge 4 commits into
Open
Fix no data bug / Replace hardcoded requester filter with dropdown#545ikenwan-dev wants to merge 4 commits into
ikenwan-dev wants to merge 4 commits into
Conversation
…charts tab. Also added Requester Drop Down filter
ikenwan-dev
requested review from
IsmailMehdi,
helloeve and
prernakakkar-google
as code owners
August 4, 2026 18:38
IsmailMehdi
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I am making this change:
Currently, the Charts (trends) page has a hardcoded filter (
df['requester'] == 'cloud-db-nl2sql-testing-jobs'), preventing users from viewing trends for evaluations triggered by other requesters.Additionally, there is a "Catch-22" UI bug on this page. If the default Agent tab (Gemini) has no data, the
if df.empty: returncheck triggers before any of the UI controls are rendered. This results in a completely blank page, hiding the Agent toggle buttons and trapping the user so they cannot switch to an Agent (like Claude) that actually does have data.What changes are being made:
trends_requester_filterto the globalStateclass inmain.pyto track the user's selection.trends_component()intrends.pyto unconditionally render the UI control elements (Agent Tabs, Requester Dropdown, Product Dropdown) at the top of the page.if df.empty:check down so it only guards the chart rendering. Now, if a filter results in zero data, a polite "No data found" warning is displayed below the buttons, allowing the user to seamlessly click a different Agent or Requester to restore data.Screenshots attached of new chart tab

