Fix GCP resource labels for mixed-case owner#6737
Open
kiryl-filatau wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GCP rejects resource labels if they contain uppercase letters (for example
owner=Name_Surname). Theownerfield in_GetResourceDictis now passed through_SafeLabelKeyOrValue, consistent with how--metadatapairs are already handled. GCE metadata (likeenable-oslogin=FALSE) is not changed.What broke
Running on GCP:
```bash
./pkb.py --cloud=GCP --benchmarks=kubernetes_scale
```
Cluster create failed:
```text
ERROR: (gcloud.container.clusters.create) ResponseError: code=400, message=Invalid field 'resource_labels.value':
"Name_Surname". It must only contain lowercase letters ([a-z]), numeric characters ([0-9]), underscores (_) and dashes (-).
International characters are allowed.
```
ownercomes from--owner/getpass.getuser()and was passed to gcloud--labelswithout lowercasing.Fix
In
perfkitbenchmarker/benchmark_spec.py(_GetResourceDict):owneris now wrapped in_SafeLabelKeyOrValue()— same as--metadatapairsOne unit test:
testOwnerFromGetuserIsSanitizedinbenchmark_spec_test.py.How was tested
python3 -m pytest tests/benchmark_spec_test.py tests/providers/gcp/util_test.py -v./pkb.py --cloud=GCP --benchmarks=kubernetes_scale— cluster create works, labels are lowercase