agent_sandbox: skeleton resource, spec, and cluster wiring#6730
Open
geojaz wants to merge 1 commit into
Open
Conversation
hubatish
approved these changes
Jun 3, 2026
Introduce the agent sandbox as a PKB resource modeled on the kubernetes inference server pattern, replacing the prior linux_package shape. This change adds only the class/spec/registration skeleton plus the cloud-agnostic container_cluster wiring. The install logic and the benchmark are added in follow-up changes. - BaseAgentSandbox resource and GetAgentSandbox factory, keyed on SANDBOX_TYPE so additional sandbox implementations can coexist. - BaseAgentSandboxConfigSpec and AgentSandboxConfigDecoder, embeddable under container_cluster in a benchmark config. - K8sAgentSandbox / K8sAgentSandboxConfigSpec: the Kubernetes (kubernetes-sigs/agent-sandbox) implementation stubs. - KubernetesCluster constructs and lifecycles cluster.agent_sandbox alongside cluster.inference_server.
2f17cb4 to
b0d7d18
Compare
This was referenced Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
First step of reshaping the agent sandbox from a
linux_packageinto a proper PKB resource, modeled on the kubernetes inference server pattern. Per review feedback on #6718.This PR is structure only: no install logic and no benchmark, so the new files can be reviewed (and mirrored internally for build files) before the implementation lands.
Changes
BaseAgentSandboxresource andGetAgentSandboxfactory, keyed onSANDBOX_TYPEso multiple sandbox implementations can coexist.BaseAgentSandboxConfigSpecandAgentSandboxConfigDecoder, embeddable undercontainer_clusterin a benchmark config.K8sAgentSandbox/K8sAgentSandboxConfigSpec(ink8s_agent_sandbox.py/k8s_agent_sandbox_spec.py): the Kubernetes (kubernetes-sigs/agent-sandbox) implementation stubs, registered undertype: Kubernetes. They raiseNotImplementedErroruntil the follow-up.KubernetesClusterconstructs and lifecyclescluster.agent_sandboxalongsidecluster.inference_server. Cloud-agnostic; no GKE/EKS changes.Notes for reviewers
BaseAgentSandbox,BaseAgentSandboxConfigSpec) so non-Kubernetes sandbox implementations can be added later under differentSANDBOX_TYPEs. The concrete Kubernetes implementation isK8sAgentSandbox.SandboxSpec(GKE Sandbox / sandboxed node pools). "Agent sandbox" here refers to the kubernetes-sigs/agent-sandbox SandboxClaim workload.Follow-ups
Subsequent PRs add the install logic (
K8sAgentSandbox._Create/_Delete), the benchmark, and the GKE/EKS/AKS provider changes.