test(schema): add discovery cache coverage#2
Open
IFAKA wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
This is ready for review. I do not have permission to request reviewers directly on this repo, but based on the repo activity @asmitapoddar looks like the right maintainer to route this. Could someone from the project please route/review when available? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FetchDiscoveryuses a fresh local cache without making a network call.Why
pkg/schemapreviously had no test coverage, while discovery caching is important for avoiding unnecessary discovery document network calls. This is a small, low-risk coverage improvement that does not require Google Health credentials or live API access.Validation
go test ./pkg/schema -vgo test ./pkg/schema -cover—40.6%coveragego test ./...go vet ./...go build -o ghealth .