fix(nativeHelm): support OCI repoUrl override for ORG_CHART deploys#125
Open
vigneshrajsb wants to merge 3 commits intomainfrom
Open
fix(nativeHelm): support OCI repoUrl override for ORG_CHART deploys#125vigneshrajsb wants to merge 3 commits intomainfrom
vigneshrajsb wants to merge 3 commits intomainfrom
Conversation
constructHelmCommand now detects OCI URLs in the ORG_CHART branch and uses the full chartRepoUrl as the chart reference instead of the bare chart name. generateHelmInstallScript extended to run helm repo add for ORG_CHART when a non-OCI custom repoUrl is present, matching the existing PUBLIC chart behavior. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… helm 3.7.x Set HELM_EXPERIMENTAL_OCI=1 unconditionally in the helm deploy container env vars. This is required for OCI registry support on helm 3.7.x and is a no-op on helm 3.8+ where OCI support became stable.
…art deploys Introduces a registry auth module that detects ECR registries from OCI repo URLs and injects an init container to authenticate before the main helm deploy step runs. The init container uses the AWS CLI to generate a temporary ECR password and calls `helm registry login`, which is then reused by `helm install`/`helm upgrade` in the main container. - registryAuth.ts: detectRegistryAuth, createRegistryAuthInitContainer, generateRegistryLoginScript - jobFactory.ts: HelmJobConfig gains registryAuth field; init container injected after clone-repo when auth is required - utils.ts: generateHelmInstallScript prepends helm registry login when registryAuth is set - helm.ts: generateHelmManifest detects ECR auth and threads it through Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a service config specifies a custom
helm.chart.repoUrl(e.g., an OCI ECR registry), the generatedhelm upgradecommand was ignoring it for services that use the org chart (goodrx-app). The command would use just the bare chart name with no repo reference:Root Cause
determineChartTypereturnsChartType.ORG_CHARTwhenchartName === orgChartName && helm.dockeris set. InconstructHelmCommand, theelsebranch (which handlesORG_CHART) unconditionally used the barechartPathand never checkedchartRepoUrl:The
generateHelmInstallScriptfunction also only ranhelm repo addforChartType.PUBLIC, skippingORG_CHARTentirely.Note:
mergeChartConfigcorrectly gives service-levelrepoUrlpriority over global config — the value was properly resolved, just never used.Fix
constructHelmCommand— add OCI detection to theORG_CHARTbranch:generateHelmInstallScript— extendhelm repo addto also coverORG_CHARTwith a non-OCI customrepoUrl:After this fix, the generated command correctly uses the OCI URL as the chart reference: