Update Password Generator to use secrets module #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update improves the password generator by replacing the standard random module with Python's `secrets` module, which is cryptographically secure. Additionally, the previous use of `password.join(...)` has been replaced with `"".join(...)` for correct concatenation of characters. Changes made: - Replaced all occurrences of `random.sample` with `secrets.choice` to enhance security. - Updated all string concatenations from `password.join(...)` to `"".join(...)` to ensure proper password formation. - Functions generate passwords according to selected character types, preserving original logic. These changes make the generated passwords safer, harder to predict, and the code more consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update improves the password generator by replacing the standard random module with Python's
secretsmodule, which is cryptographically secure. Additionally, the previous use ofpassword.join(...)has been replaced with"".join(...)for correct concatenation of characters.Changes made:
random.samplewithsecrets.choiceto enhance security.password.join(...)to"".join(...)to ensure proper password formation.These changes make the generated passwords safer, harder to predict, and the code more consistent.