ci: add a non-blocking Windows test lane for the shipped CLIs#237
Merged
Conversation
We ship `gl` and `git-remote-gitlawb` to Windows users via release.yml but run no Windows tests: pr-checks.yml is ubuntu-only, and the single windows-latest in the repo is the release build step, which never runs `cargo test`. So changes to the shipped Windows CLIs (e.g. the multi-round fetch fix in #192) reach Windows users with zero test runs on Windows. Add a `test-windows` job that runs `cargo test -p gl -p git-remote-gitlawb` on windows-latest with `continue-on-error: true`, mirroring the informational beta lane: a Windows-only failure is visible on the PR but does not block merge. The two crates are the client CLIs and depend on no database, so the job needs no Postgres service (service containers do not run on windows-latest regardless); git is preinstalled on the runner for the real_git_fetch harness. This makes the #[cfg(windows)] regressions from #192 load-bearing instead of never-run. Un-gating the currently #[cfg(unix)] harness tests is the deferred follow-on in #228.
Contributor
📝 WalkthroughWalkthroughThe pull-request workflow adds a non-blocking ChangesWindows CI coverage
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
test-windowsjob topr-checks.ymlthat runscargo test -p gl -p git-remote-gitlawbonwindows-latest, non-blocking (continue-on-error: true).Why
We ship
glandgit-remote-gitlawbto Windows users viarelease.yml, but run no Windows tests:pr-checks.ymlis ubuntu-only, and the onewindows-latestin the repo is the release build step, which never runscargo test. So changes to the shipped Windows CLIs (for example the multi-round fetch fix in #192) reach Windows users with zero test runs on Windows.The lane makes Windows-only regressions visible on the PR without gating merge, mirroring the existing informational
betalane. The two crates are the client CLIs and depend on no database, so the job needs no Postgres service (service containers do not run onwindows-latestanyway);gitis preinstalled on the runner for thereal_git_fetchharness.Notes
release.yml.#[cfg(unix)]harness tests so they exercise the shipped Windows path is the deferred follow-on in Add a non-blocking Windows CI lane for the shipped gl / git-remote-gitlawb binaries #228.Closes #228.
Summary by CodeRabbit