Skip to content

ci: add a non-blocking Windows test lane for the shipped CLIs#237

Merged
kevincodex1 merged 1 commit into
mainfrom
fix/issue-228-windows-ci
Jul 22, 2026
Merged

ci: add a non-blocking Windows test lane for the shipped CLIs#237
kevincodex1 merged 1 commit into
mainfrom
fix/issue-228-windows-ci

Conversation

@beardthelion

@beardthelion beardthelion commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

What

Adds a test-windows job to pr-checks.yml that runs cargo test -p gl -p git-remote-gitlawb on windows-latest, non-blocking (continue-on-error: true).

Why

We ship gl and git-remote-gitlawb to Windows users via release.yml, but run no Windows tests: pr-checks.yml is ubuntu-only, and the one windows-latest in the repo is the release build step, which never runs cargo test. So changes to the shipped Windows CLIs (for example the multi-round fetch fix in #192) reach Windows users with zero test runs on Windows.

The lane makes Windows-only regressions visible on the PR without gating merge, mirroring the existing informational beta lane. The two crates are the client CLIs and depend on no database, so the job needs no Postgres service (service containers do not run on windows-latest anyway); git is preinstalled on the runner for the real_git_fetch harness.

Notes

  • Non-blocking is deliberate. This is the first time these suites run on Windows, so the first run may surface real failures; those should be visible, not block merge, matching the best-effort Windows posture already in release.yml.
  • Un-gating the currently #[cfg(unix)] harness tests so they exercise the shipped Windows path is the deferred follow-on in Add a non-blocking Windows CI lane for the shipped gl / git-remote-gitlawb binaries #228.

Closes #228.

Summary by CodeRabbit

  • Tests
    • Added non-blocking Windows test coverage for the shipped Windows components.
    • Windows tests now run automatically with Rust tooling and dependency caching.

We ship `gl` and `git-remote-gitlawb` to Windows users via release.yml but run
no Windows tests: pr-checks.yml is ubuntu-only, and the single windows-latest in
the repo is the release build step, which never runs `cargo test`. So changes to
the shipped Windows CLIs (e.g. the multi-round fetch fix in #192) reach Windows
users with zero test runs on Windows.

Add a `test-windows` job that runs `cargo test -p gl -p git-remote-gitlawb` on
windows-latest with `continue-on-error: true`, mirroring the informational beta
lane: a Windows-only failure is visible on the PR but does not block merge. The
two crates are the client CLIs and depend on no database, so the job needs no
Postgres service (service containers do not run on windows-latest regardless);
git is preinstalled on the runner for the real_git_fetch harness.

This makes the #[cfg(windows)] regressions from #192 load-bearing instead of
never-run. Un-gating the currently #[cfg(unix)] harness tests is the deferred
follow-on in #228.
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The pull-request workflow adds a non-blocking windows-latest job that installs stable Rust, caches Cargo dependencies, and tests the gl and git-remote-gitlawb crates.

Changes

Windows CI coverage

Layer / File(s) Summary
Add Windows test lane
.github/workflows/pr-checks.yml
Adds an informational Windows job with stable Rust, a Windows Cargo cache, and scoped tests for gl and git-remote-gitlawb.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • Gitlawb/node#57: Also modifies the pull-request checks workflow and its test scheduling.

Suggested labels: kind:ci

Suggested reviewers: kevincodex1

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR adds the requested non-blocking Windows CI lane for gl and git-remote-gitlawb on windows-latest.
Out of Scope Changes check ✅ Passed The only change is the requested Windows CI job; no unrelated scope appears introduced.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly summarizes the main change: adding a non-blocking Windows CI lane for the shipped CLIs.
Description check ✅ Passed The description covers what changed, why it matters, and notes the non-blocking intent, though it omits some template sections.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-228-windows-ci

Comment @coderabbitai help to get the list of available commands.

@beardthelion beardthelion added the kind:ci CI, release, or packaging pipeline label Jul 22, 2026

@kevincodex1 kevincodex1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kevincodex1
kevincodex1 merged commit b484a24 into main Jul 22, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:ci CI, release, or packaging pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a non-blocking Windows CI lane for the shipped gl / git-remote-gitlawb binaries

2 participants