docs: note credential-source:gcp and the jwt_key raw-PEM encoding rule - #36
Merged
Merged
Conversation
sf-org-login's action.yml comment already states this; the reference doc was written before PR #33 added credential-source:gcp and didn't carry it. Root-caused for real against a live salesforce-devhub secret and a GitHub Actions run — see gforce-google-infra's docs/SECRETS.md for the seeding side of the same rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sf-org-login's reference entry indocs/claude-actions-reference.mdpredates PR feat(sf-org-login): add credential-source gcp, via new gcp-secret-get action #33 (credential-source: gcp) and didn't carry the encoding contract that action.yml's own comments already state.jwt_keyfield must be the raw PEM (this action base64-encodes it itself); a pre-encoded value fails with "Decoded JWT key is not a PEM private key".gforce-google-infra(the actual seeding side, where this went wrong): Gforce-Innovation-Kft/gforce-google-infra#3Context
Root-caused for real:
salesforce-devhub'sjwt_keywas seeded from the base64-encoded key file instead of the raw PEM, breakingcredential-source: gcpwith exactly this error. Verified live viagcp-secret-get+sf-org-loginruns fromsf-develop-demo(WIF-trusted), confirmed via hash comparison against the local key files (no key material ever printed), and fixed by reseeding — this PR is the doc fix so it isn't seeded wrong again.Test plan
npm run allpassed (format, lint, typecheck, bundle, tests, dist:verify)🤖 Generated with Claude Code