fix(gcp-secret-get): set export_to_environment: true - #34
Merged
Conversation
google-github-actions/get-secretmanager-secrets@v3 defaults this to false -- without it, $SECRET_JSON is empty in the next step even after a successful fetch, so the JSON-parse guard fires with "Secret ... is empty or not valid JSON" even though the fetch genuinely worked. Caught by the first real end-to-end run of sf-org-login's gcp branch against the live salesforce-devhub secret.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
google-github-actions/get-secretmanager-secrets@v3defaultsexport_to_environmenttofalse. Without setting it explicitly,$SECRET_JSONis empty in the next step even after a successful fetch — the JSON-parse guard then (correctly) fires with "Secret ... is empty or not valid JSON", masking a working fetch as a broken one.sf-org-login's newgcpbranch against the livesalesforce-devhubsecret (sf-external-app-bootstrap'ssetup-external-app.yml, run 32396528969) — auth succeeded, the fetch action itself reported success, but the export step had nothing to read.Test plan
actionlintcleannpm run all— unaffected (composite-action-only change), all green via the pre-push hooksetup-external-app.ymlagainstdevhubonce this lands and@v2moves🤖 Generated with Claude Code