Skip to content

fix(llc): error before reconnect strategy fix - #1325

Open
Brazol wants to merge 1 commit into
mainfrom
fix/error-before-reconnect-flow-fix
Open

fix(llc): error before reconnect strategy fix#1325
Brazol wants to merge 1 commit into
mainfrom
fix/error-before-reconnect-flow-fix

Conversation

@Brazol

@Brazol Brazol commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved call reconnection stability when unexpected errors occur.
    • Reconnection attempts now use a delay and can escalate to rejoining the call instead of retrying immediately in a loop.
  • Documentation
    • Added upcoming release notes describing the reconnection behavior improvement.

@Brazol
Brazol requested a review from a team as a code owner September 3, 2026 10:01
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: d2770dcf-8802-4b9b-95a5-ce5a8f9bcbb7

📥 Commits

Reviewing files that changed from the base of the PR and between bc0a789 and 36b180d.

📒 Files selected for processing (5)
  • packages/stream_video/CHANGELOG.md
  • packages/stream_video/lib/src/call/call.dart
  • packages/stream_video/test/src/call/call_reconnect_stability_test.dart
  • packages/stream_video/test/test_helpers.dart
  • packages/stream_video_flutter/CHANGELOG.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The reconnect loop now applies backoff and possible rejoin escalation when unexpected errors occur before the reconnect strategy. Tests inject a throwing telemetry reporter and verify throttled attempts. Both package changelogs document the fix.

Changes

Reconnect stability

Layer / File(s) Summary
Reconnect failure handling
packages/stream_video/lib/src/call/call.dart, packages/stream_video/CHANGELOG.md, packages/stream_video_flutter/CHANGELOG.md
Unexpected reconnect errors now use backoff and can escalate to rejoin. The error counter resets after a completed attempt. Changelogs document the behavior.
Reconnect regression coverage
packages/stream_video/test/src/call/call_reconnect_stability_test.dart, packages/stream_video/test/test_helpers.dart
Tests can inject a telemetry reporter that throws during join-attempt reporting. The reconnect test verifies that attempts remain throttled.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 36b18

This change makes reconnect failures before strategy execution back off and escalate to rejoin rather than spin immediately. The updated reconnect regression coverage and completed review leave no actionable merge-blocking risk.

Suggested reviewers: renefloor

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request has no description. It does not include the required goal, implementation details, testing information, or checklist sections from the repository template. Add a description using the repository template. Explain the reconnect-loop fix, implementation details, testing performed, and checklist status.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies the reconnect-strategy error fix, which matches the main change. The wording is awkward but remains specific and relevant.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/error-before-reconnect-flow-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 12.71%. Comparing base (bc0a789) to head (36b180d).

Files with missing lines Patch % Lines
packages/stream_video/lib/src/call/call.dart 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1325      +/-   ##
==========================================
+ Coverage   12.68%   12.71%   +0.02%     
==========================================
  Files         680      680              
  Lines       50570    50574       +4     
==========================================
+ Hits         6417     6430      +13     
+ Misses      44153    44144       -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants