[Telecom-2] Extract incoming-call coordination - #1808
Conversation
PR checklist ❌The following issues were detected:
What we check
|
SDK Size Comparison 📏
|
c34c074 to
9f185c2
Compare
9f185c2 to
f6fdcbf
Compare
f6fdcbf to
bf41261
Compare
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. WalkthroughChangesThe incoming call flow now uses Incoming Call Coordination
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to Incoming-call coordination is moved behind an internal coordinator while preserving the existing presentation, Telecom, notification, and dismissal flows. No concrete merge-blocking risk remains. Sequence Diagram(s)sequenceDiagram
participant ServiceLauncher
participant IncomingCallCoordinator
participant IncomingCallPresenter
participant JetpackTelecomRepository
ServiceLauncher->>IncomingCallCoordinator: showIncomingCall(request)
IncomingCallCoordinator->>IncomingCallPresenter: start incoming-call service
IncomingCallCoordinator->>JetpackTelecomRepository: register incoming video call
ServiceLauncher->>IncomingCallCoordinator: dismissIncomingCall(callId, config)
IncomingCallCoordinator->>IncomingCallPresenter: start removal service
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |


Goal
Closes #AND-1491
Extract incoming-call coordination
Implementation
IncomingCallRequestandIncomingCallCoordinatorPreAndroid17IncomingCallCoordinatorServiceLauncheras the routing boundaryPublic API changes
IncomingCallRequest,IncomingCallCoordinator, and the coordinator implementation remain internal.Stack
PR 2 of 5. Depends on #1807.
Testing
ServiceLauncherunit testsSummary by CodeRabbit