Skip to content

[PBE-000] initial support for reaction ranking #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[PBE-000] initial support for reaction ranking #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e7a5da
chore: add ranking parameter to reaction options
xernobyl Jan 16, 2024
401009a
chore: add ranking to reaction filter
xernobyl Jan 16, 2024
53c749a
chore: lint fix
xernobyl Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/Models/Reaction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ public class ReactionFiltering
private const int DefaultLimit = 10;
private int _limit = DefaultLimit;
private ReactionFilter _filter = null;
private string _ranking = null;

public ReactionFiltering WithLimit(int limit)
{
Expand All @@ -67,10 +68,21 @@ internal ReactionFiltering WithActivityData()

internal void Apply(RestRequest request)
{
if (!string.IsNullOrEmpty(_ranking))
{
request.AddQueryParameter("ranking", _ranking);
}

request.AddQueryParameter("limit", _limit.ToString());
_filter?.Apply(request);
}

public ReactionFiltering WithRanking(string ranking)
{
_ranking = ranking;
return this;
}

internal bool IncludesActivityData => _filter.IncludesActivityData;

public static ReactionFiltering Default => new ReactionFiltering().WithLimit(DefaultLimit);
Expand Down
10 changes: 10 additions & 0 deletions src/Models/ReactionOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ private enum OpType

private string _userId;
private string _childrenUserId;
private string _ranking;

private ReactionOption()
{
Expand Down Expand Up @@ -54,6 +55,9 @@ internal void Apply(RestRequest request)

if (!string.IsNullOrWhiteSpace(_childrenUserId))
request.AddQueryParameter("children_user_id", _userId);

if (!string.IsNullOrWhiteSpace(_ranking))
request.AddQueryParameter("ranking", _userId);
}

public static ReactionOption With()
Expand Down Expand Up @@ -108,5 +112,11 @@ public ReactionOption ChildrenUserFilter(string value)
_childrenUserId = value;
return this;
}

public ReactionOption RankingFilter(string ranking)
{
_ranking = ranking;
return this;
}
}
}