feat: unify channel and thread display titles#2998
Open
MartinCupela wants to merge 1 commit intomasterfrom
Open
feat: unify channel and thread display titles#2998MartinCupela wants to merge 1 commit intomasterfrom
MartinCupela wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Depends on GetStream/stream-chat-js#1699
Remove
ThreadHeaderMaincomponent as it is not necessary anymore (introduced temporarily due to different designs)Hook
useChannelPreviewInfonow generates data by subscribing to channel displayStore and membersStore; derive groupChannelDisplayInfo from membersStore (no getGroupChannelDisplayInfo).GroupAvatar/ChannelAvatar: rename prop members →displayMembers.ThreadHeaderuse channel display from store; fallback without thread to channel display then parent message author (name only).BREAKING CHANGE: useChannelPreviewInfo now always returns a defined
groupChannelDisplayInfo(object withmembersandoverflowCount). For 1:1 or ≤2 members it returns{ members: [], overflowCount: undefined }. Code that treatedgroupChannelDisplayInfo == nullas “not a group” should use e.g.groupChannelDisplayInfo.members.length >= 2instead.