fix: make vite example channel selection bookmarkable#2997
Open
fix: make vite example channel selection bookmarkable#2997
Conversation
|
Size Change: +1 B (0%) Total Size: 428 kB
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Make the Vite example channel selection bookmarkable and shareable by syncing the active channel with the URL.
🛠 Implementation details
channelquery param in the Vite example and pass it toChannelList.customActiveChannel.history.replaceStatewhile preserving existing params liketokenanduser_id.customActiveChannelis missing or invalid.customActiveChannelfallback behavior.matchMediaJest polyfill and missing React imports needed for the exercised test path.🎨 UI Changes
N/A. This changes URL state only.