fix: respect topInset on bottom sheet once again#3606
Merged
Conversation
Contributor
SDK Size
|
szuperaz
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This PR addresses a regression with our
AttachmentPickercomponent which was done in order to fix accessibility issues. Namely, since we calculate thetopInsetfor ourBottomSheetin order to make it properly orderable by screen readers, the value for the globaltopInsetwas omitted.This is wrong, because then the calculations are very wrong particularly in the cases of having native modals (i.e
react-navigation/native-stackorexpo-router) whose height we need to take into account, similarly to how we do it forkeyboardVerticalOffset.🛠 Implementation details
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch