Skip to content

fix: remove keyboard controller remnants#3605

Merged
isekovanic merged 3 commits into
developfrom
fix/remove-keyboard-controller-remnants
May 19, 2026
Merged

fix: remove keyboard controller remnants#3605
isekovanic merged 3 commits into
developfrom
fix/remove-keyboard-controller-remnants

Conversation

@isekovanic
Copy link
Copy Markdown
Contributor

🎯 Goal

This PR removes remnants of react-native-keyboard-controller which we initially wanted to add to the SDK in a first line support fashion. However, since it was a bit rushed it was not up to our standards in terms of quality and so we decided to remove it (hence why it isn't mentioned in the docs). This was due to the complexity of the integration within our SDK specifically, not the library itself (the library's really really great and we actively recommend using it if your project allows it).

However, some remnants of it spilled over in a way that it forces react-native-keyboard-controller to be used if it's installed. This is obviously not ideal as a lot of the issues did not get polished out and so integrations that previously used react-native-keyboard-controller elsewhere have a buggy handling of pretty much everything keyboard related.

With this change this should be resolved.

🛠 Implementation details

🎨 UI Changes

iOS
Before After
Android
Before After

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@isekovanic isekovanic requested review from oliverlaz and szuperaz May 19, 2026 14:17
@Stream-SDK-Bot
Copy link
Copy Markdown
Contributor

SDK Size

title develop branch diff status
js_bundle_size 368 KB 368 KB -870 B 🚀

@isekovanic isekovanic merged commit 2dedcd6 into develop May 19, 2026
5 checks passed
@isekovanic isekovanic deleted the fix/remove-keyboard-controller-remnants branch May 19, 2026 14:25
@github-actions github-actions Bot mentioned this pull request May 19, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants