-
Notifications
You must be signed in to change notification settings - Fork 386
fix(ui, localization): improved semantics on message #2928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renefloor
wants to merge
24
commits into
master
Choose a base branch
from
feat/flu-592-improved-semantics-on-message
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
fcacdd8
fix(ui, localization): announce message sender and direction to scree…
renefloor 6cede96
fix(ui): fold delivery status into the message row phrase, fix date d…
renefloor 660411e
fix(ui, localization): label message-list attachment tiles for screen…
renefloor d92411e
fix(ui): keep the timestamp and delivery status on a deleted message
renefloor 7b61439
fix(ui): drop the edited marker from a deleted message
renefloor 0f6b347
fix(ui, localization): announce who replied to whom on a quoted message
renefloor c0bc8b3
docs(changelog): collapse the message a11y entries into one
renefloor 1bef9f4
fix(ui): announce attachment upload progress instead of a bare "Sending"
renefloor 6fdedb2
fix(ui, localization): announce a message that failed to send
renefloor 90b36a1
Merge branch 'master' into renefloor/flu-592-announce-message-sender-…
renefloor c597c74
fix(ui): announce the message text the bubble actually shows
renefloor 5009b73
docs(ui): explain the unnamed-sender fallback in the message a11y label
renefloor 33d8035
fix(ui): don't default the reader's language when announcing message …
renefloor 06d1155
fix(ui, localization): address review findings on the message a11y work
renefloor dab683a
fix(ui): don't take an authorless message for the reader's own
renefloor a5795b9
Merge branch 'master' into renefloor/flu-592-announce-message-sender-…
renefloor 38a4361
refactor(ui): give the message delivery status one source of truth
renefloor 79ce4d8
fix(ui): announce message metadata outside a labeled message row
renefloor 6d25b63
fix(ui): keep an own message rendered before its channel is watched
renefloor 06d4864
fix(ui): announce the delivery status only when the message shows one
renefloor 6519a1e
fix(ui): announce the rendered message text, not its markdown source
renefloor 6b45dc4
fix(localizations): conjugate the quoted-reply labels for whoever rep…
renefloor a12dfa9
docs(ui): file the new accessibility API under Added
renefloor 3ac850f
improvements on link preview attachment
renefloor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.