perf(persistence): Move pinned messages pagination to SQL

[VelikovPetar]

Submit a pull request

Linear: FLU-487

CLA

• I have signed the Stream CLA (required).
• The code changes follow best practices
• Code changes are tested (add some information if not applicable)

Description of the pull request

Port of #2689 to the v9 branch.

• Refactor the pinned messages pagination to be performed on SQL level, instead of fetching all pinned messages from DB, then paginating in-memory.
• Fix limit always being applied from the beginning of the fetched messages.
• Add support for greaterThanOrEqual/lessThanOrEqual pagination.

Adaptation from master: v9's PinnedMessageDao._messagesFromJoinRows has no fetchSharedLocation parameter, so the call site only forwards fetchDraft. Everything else mirrors the original PR.

Screenshots / Videos

N/A — internal DAO refactor.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9eeb51dc-9afb-49a4-9e10-58bd83e930a1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/FLU-487_move_pinned_message_pagination_to_sql_v9

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.99%. Comparing base (e19b1ce) to head (f42277c).

Additional details and impacted files

@@            Coverage Diff             @@
##               v9    #2751      +/-   ##
==========================================
+ Coverage   65.96%   65.99%   +0.02%     
==========================================
  Files         425      425              
  Lines       26926    26949      +23     
==========================================
+ Hits        17761    17784      +23     
  Misses       9165     9165              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.