fix: don't claim main model summarized after dual compaction failure#19
Merged
morganlinton merged 2 commits intoJul 17, 2026
Merged
Conversation
When the compaction model fails (or is unavailable) and the main-model
retry also fails, the harness still deterministic-trims, but the notice
must not say "summarized with {main}". Set warnings only after the final
outcome so a failed fallback never mislabels a trim as a summary.
morganlinton
approved these changes
Jul 17, 2026
morganlinton
left a comment
morganlinton
left a comment
Contributor
There was a problem hiding this comment.
Looks good — warnings are applied only after the final compaction outcome, so dual failure no longer mislabels a deterministic trim as “summarized with {main}”. Nice regression coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cargo test compaction_cargo clippy --all-targets -- -D warningscargo fmt --all -- --check