Add ShpWriter and ShxWriter. Reduce clutter from tests, by using temp dirs for writing shapefiles.#402
Merged
Conversation
Add ShpWriter and ShxWriter. Reduce clutter from tests, by using temp dirs for writing shapefiles. Create ShpWriter as well as ShxWriter Bug fixes Delete merge & edit. Move test shapefiles out of test into parent dir (shapefiles) Update name of _replace_remote_url_with_localhost Restore _replace_remote_url_with_localhost as it's used by test_shapefiles.py Add clear_globs=True to doctest runner .run Quote replaced localhost URLs in doctests Close all Reader handles to shapefiles/tests, and reorder jobs to fail faster Don't close Reader before it's read from
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ShpWriter and ShxWriter. Reduce clutter from tests, by using temp dirs for writing shapefiles.
Create ShpWriter as well as ShxWriter
Bug fixes
Delete merge & edit. Move test shapefiles out of test into parent dir (shapefiles)
Update name of _replace_remote_url_with_localhost
Restore _replace_remote_url_with_localhost as it's used by test_shapefiles.py
Add clear_globs=True to doctest runner .run
Quote replaced localhost URLs in doctests
Close all Reader handles to shapefiles/tests, and reorder jobs to fail faster
Don't close Reader before it's read from