Skip to content

Make Reader and Writer stricter about their args. Use pathlib.Paths … #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesParrott merged 1 commit into from
May 26, 2026
Merged

Make Reader and Writer stricter about their args. Use pathlib.Paths … #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,14 @@ part of your geospatial project.

## 3.0.9.dev
### Bug fixes
- BREAKING CHANGE. Reader now raises TypeError instead of failing silently (e.g. in anticipation
of a subsequent call to Reader.load), when passed an unsupported truthy Python object (not a str
or a Path) as its first arg (the positional-only, non-keyword arg).
- Remove ambiguity in API (BREAKING CHANGE). Reader and Writer now both raise TypeError
when passed a supported Shapefile target
as the positional-only, non-keyword arg, but also passed kwargs for shp, dbf or shx (instead
of silently dropping or overwriting those kwargs, with the user being none the wiser).
- Bug fix (BREAKING CHANGE). Reader and Writer now raise TypeError instead of continuing silently
as if given no args (e.g. in anticipation of a subsequent call to Reader.load), when passed an unsupported
truthy Python object (not a str or a Path) as its first arg (the positional-only, non-keyword arg).

- BREAKING CHANGE. Correct NODATA lower threshold to -1e38 (as per [spec](https://www.esri.com/content/dam/esrisites/sitecore-archive/Files/Pdfs/library/whitepapers/pdfs/shapefile.pdf) 2, Numeric Types). This is 10% of
PyShp's previous threshold -10e38, so it is possible large negative values x (-1e39 < x < -1e38 will now be NODATA.

Expand Down
11 changes: 8 additions & 3 deletions changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
VERSION 3.0.9.dev

2026-05-26
Remove ambiguity in API (BREAKING CHANGE):
* Reader and Writer now both raise TypeError when passed a supported Shapefile target
as the positional-only, non-keyword arg, and also kwargs for shp, dbf or shx (instead
of silently dropping or overwriting those kwargs, with the user being none the wiser).
2026-05-26
Bug fix (BREAKING CHANGE):
* Reader now raises TypeError instead of failing silently (e.g. in anticipation of a subsequent call
to Reader.load), when passed an unsupported truthy Python object (not a str or a Path) as its first
arg (the positional-only, non-keyword arg).
* Reader and Writer now raise TypeError instead of continuing silently, as if given no args
(e.g. in anticipation of a subsequent call to Reader.load), when passed an unsupported
truthy Python object (not a str or a Path) as its first arg (the positional-only, non-keyword arg).

2026-05-23
Bug fix (BREAKING CHANGE):
Expand Down
Loading
Loading