Add ShpReader and ShxReader#398
Merged
Merged
Conversation
Add ShxReader Add ShpReader Can combine ._shape too if rec length yielded/cached (as well as pos) Is it still necessary to support out of spec shapefiles, with next_shape_pos? Cache iterator in ShpReader Use a cached generator Passes pytest, mypy and ruff check Reformat and run hooks Update test_shapefile.py Swap out Nones in MBox part of header Update shapefile.py Add ISDATA_LOWER_BOUND =-1e38 to differentiate from NODATA = -1e39 (as per legacy) Add zbox and mbox properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ShxReader
Add ShpReader
Can combine ._shape too if rec length yielded/cached (as well as pos)
Is it still necessary to support out of spec shapefiles, with next_shape_pos?
Cache iterator in ShpReader
Use a cached generator
Passes pytest, mypy and ruff check
Reformat and run hooks
Update test_shapefile.py
Swap out Nones in MBox part of header
Update shapefile.py
Add ISDATA_LOWER_BOUND =-1e38 to differentiate from NODATA = -1e39 (as per legacy)
Add zbox and mbox properties