Refine reverse NTv2 shifts at the estimated source coordinate - #173
Open
timothyanderson096-ocdealcheck wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #169.
Implements the single reverse refinement proposed in the issue. After estimating the source coordinate, the transformation evaluates the grid shifts there and applies those refined shifts to the original target coordinate. An estimate outside the grid raises the existing extent error.
Adds self-contained regression tests covering both interpolation methods, positive and negative shifts, interpolation-cell crossings, repeated round trips and an estimate leaving the grid. Expected coordinates are calculated independently of the forward implementation.
Validation:
One refinement reduces the error; it does not guarantee exact inversion for arbitrary grids. Existing rounding and bicubic boundary behavior remain unchanged, keeping #171 and #170 separate.