Skip to content

fix(Refactor): refactor functions in shared - #471

Open
JulienChampagnol wants to merge 27 commits into
nextfrom
feat/app_controller
Open

fix(Refactor): refactor functions in shared#471
JulienChampagnol wants to merge 27 commits into
nextfrom
feat/app_controller

Conversation

@JulienChampagnol

Copy link
Copy Markdown
Member

No description provided.

Comment thread shared/utils/fetch_raw.js Outdated
{ onRequestError, onResponse, onResponseError } = {},
) {
if (expectEvent) {
headers["Accept"] = "text/event-stream";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

append if not empty, assign else

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shared/response_handlers/load.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants