Skip to content

feat(Python): support up to 3.14#1287

Merged
BotellaA merged 22 commits into
nextfrom
feat/py314
Jun 12, 2026
Merged

feat(Python): support up to 3.14#1287
BotellaA merged 22 commits into
nextfrom
feat/py314

Conversation

@BotellaA

Copy link
Copy Markdown
Member

No description provided.

@BotellaA BotellaA requested a review from panquez June 11, 2026 07:11
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 7 concern(s)
  • include/geode/mesh/helpers/detail/component_identifier.hpp:41:1: warning: [modernize-concat-nested-namespaces]

    nested namespaces can be concatenated

       41 | namespace geode
          | ^~~~~~~~~~~~~~~
       42 | {
          | ~
       43 |     namespace detail
          |     ~~~~~~~~~~~~~~~~
          |     namespace geode::detail
  • src/geode/mesh/helpers/detail/component_identifier.cpp:62:1: warning: [modernize-concat-nested-namespaces]

    nested namespaces can be concatenated

       62 | namespace geode
          | ^~~~~~~~~~~~~~~
       63 | {
          | ~
       64 |     namespace detail
          |     ~~~~~~~~~~~~~~~~
          |     namespace geode::detail
  • src/geode/mesh/helpers/detail/component_identifier.cpp:74:13: warning: [modernize-use-nodiscard]

    function 'identifier' should be marked [[nodiscard]]

       74 |             index_t identifier( index_t element ) const
          |             ^
          |             [[nodiscard]] 
  • src/geode/mesh/helpers/detail/component_identifier.cpp:100:13: warning: [modernize-use-nodiscard]

    function 'identified_components' should be marked [[nodiscard]]

      100 |             absl::FixedArray< std::vector< index_t > >
          |             ^
          |             [[nodiscard]] 
  • src/geode/mesh/helpers/detail/component_identifier.cpp:118:13: warning: [modernize-use-nodiscard]

    function 'mesh' should be marked [[nodiscard]]

      118 |             const Mesh& mesh() const
          |             ^
          |             [[nodiscard]] 
  • src/geode/mesh/helpers/detail/component_identifier.cpp:125:17: warning: [bugprone-easily-swappable-parameters]

    3 adjacent parameters of 'propagate' of similar type ('index_t') are easily swapped by mistake

      125 |                 index_t element_from, index_t tag_id, index_t nb_max_elements )
          |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    /__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/component_identifier.cpp:125:25: note: the first parameter in the range is 'element_from'
      125 |                 index_t element_from, index_t tag_id, index_t nb_max_elements )
          |                         ^~~~~~~~~~~~
    /__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/component_identifier.cpp:125:63: note: the last parameter in the range is 'nb_max_elements'
      125 |                 index_t element_from, index_t tag_id, index_t nb_max_elements )
          |                                                               ^~~~~~~~~~~~~~~
  • src/geode/mesh/helpers/detail/component_identifier.cpp:144:26: warning: [portability-template-virtual-member-function]

    unspecified virtual member function instantiation; the virtual member function is not instantiated but it might be with a different compiler

      144 |             virtual void add_adjacents(
          |                          ^
    /__w/OpenGeode/OpenGeode/src/geode/mesh/helpers/detail/component_identifier.cpp:153:46: note: template instantiated here
      153 |         class GraphIdentifier::Impl : public Propagator< Graph >
          |                                              ^

Have any feedback or feature suggestions? Share it here.

@BotellaA BotellaA merged commit 54661ba into next Jun 12, 2026
19 checks passed
@BotellaA BotellaA deleted the feat/py314 branch June 12, 2026 10:35
@BotellaA

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 17.3.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 17.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants