feat(Validity): Added validity checks for all meshes by MelchiorSchuh · Pull Request #179 · Geode-solutions/OpenGeode-Inspector

MelchiorSchuh · 2026-06-05T10:45:38Z

No description provided.

github-actions · 2026-06-05T10:49:14Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 191 concern(s)

bindings/python/src/inspection/topology/brep_topology.hpp:31:42: error: [clang-diagnostic-error]

use of undeclared identifier 'pybind11'

   31 |     void define_brep_topology_inspector( pybind11::module& module )
      |                                          ^

bindings/python/src/inspection/topology/brep_topology.hpp:33:9: error: [clang-diagnostic-error]

use of undeclared identifier 'pybind11'
```
   33 |         pybind11::class_< BRepCornersTopologyInspectionResult >(
      |         ^
```

bindings/python/src/inspection/topology/brep_topology.hpp:33:27: error: [clang-diagnostic-error]

'BRepCornersTopologyInspectionResult' does not refer to a value

   33 |         pybind11::class_< BRepCornersTopologyInspectionResult >(
      |                           ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/include/geode/inspector/inspection/topology/brep_corners_topology.hpp:44:44: note: declared here
   44 |         opengeode_inspector_inspection_api BRepCornersTopologyInspectionResult
      |                                            ^

bindings/python/src/inspection/topology/brep_topology.hpp:35:19: error: [clang-diagnostic-error]

use of undeclared identifier 'pybind11'
```
   35 |             .def( pybind11::init<>() )
      |                   ^
```
bindings/python/src/inspection/topology/brep_topology.hpp:35:34: error: [clang-diagnostic-error]

expected expression
```
   35 |             .def( pybind11::init<>() )
      |                                  ^
```
bindings/python/src/inspection/topology/brep_topology.hpp:35:36: error: [clang-diagnostic-error]

expected expression
```
   35 |             .def( pybind11::init<>() )
      |                                    ^
```
bindings/python/src/inspection/topology/brep_topology.hpp:60:9: error: [clang-diagnostic-error]

use of undeclared identifier 'pybind11'
```
   60 |         pybind11::class_< BRepLinesTopologyInspectionResult >(
      |         ^
```

bindings/python/src/inspection/topology/brep_topology.hpp:60:27: error: [clang-diagnostic-error]

'BRepLinesTopologyInspectionResult' does not refer to a value

   60 |         pybind11::class_< BRepLinesTopologyInspectionResult >(
      |                           ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/include/geode/inspector/inspection/topology/brep_lines_topology.hpp:43:47: note: declared here
   43 |     struct opengeode_inspector_inspection_api BRepLinesTopologyInspectionResult
      |                                               ^

bindings/python/src/inspection/topology/brep_topology.hpp:62:19: error: [clang-diagnostic-error]

use of undeclared identifier 'pybind11'
```
   62 |             .def( pybind11::init<>() )
      |                   ^
```
bindings/python/src/inspection/topology/brep_topology.hpp:62:34: error: [clang-diagnostic-error]

expected expression
```
   62 |             .def( pybind11::init<>() )
      |                                  ^
```
bindings/python/src/inspection/topology/brep_topology.hpp:62:36: error: [clang-diagnostic-error]

expected expression
```
   62 |             .def( pybind11::init<>() )
      |                                    ^
```
bindings/python/src/inspection/topology/brep_topology.hpp:91:9: error: [clang-diagnostic-error]

use of undeclared identifier 'pybind11'
```
   91 |         pybind11::class_< BRepSurfacesTopologyInspectionResult >(
      |         ^
```

bindings/python/src/inspection/topology/brep_topology.hpp:91:27: error: [clang-diagnostic-error]

'BRepSurfacesTopologyInspectionResult' does not refer to a value

   91 |         pybind11::class_< BRepSurfacesTopologyInspectionResult >(
      |                           ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/include/geode/inspector/inspection/topology/brep_surfaces_topology.hpp:42:44: note: declared here
   42 |         opengeode_inspector_inspection_api BRepSurfacesTopologyInspectionResult
      |                                            ^

bindings/python/src/inspection/topology/brep_topology.hpp:93:19: error: [clang-diagnostic-error]

use of undeclared identifier 'pybind11'
```
   93 |             .def( pybind11::init<>() )
      |                   ^
```
bindings/python/src/inspection/topology/brep_topology.hpp:93:34: error: [clang-diagnostic-error]

expected expression
```
   93 |             .def( pybind11::init<>() )
      |                                  ^
```
bindings/python/src/inspection/topology/brep_topology.hpp:93:36: error: [clang-diagnostic-error]

expected expression
```
   93 |             .def( pybind11::init<>() )
      |                                    ^
```
bindings/python/src/inspection/topology/brep_topology.hpp:119:9: error: [clang-diagnostic-error]

use of undeclared identifier 'pybind11'
```
  119 |         pybind11::class_< BRepBlocksTopologyInspectionResult >(
      |         ^
```

bindings/python/src/inspection/topology/brep_topology.hpp:119:27: error: [clang-diagnostic-error]

'BRepBlocksTopologyInspectionResult' does not refer to a value

  119 |         pybind11::class_< BRepBlocksTopologyInspectionResult >(
      |                           ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/include/geode/inspector/inspection/topology/brep_blocks_topology.hpp:46:47: note: declared here
   46 |     struct opengeode_inspector_inspection_api BRepBlocksTopologyInspectionResult
      |                                               ^

bindings/python/src/inspection/topology/brep_topology.hpp:121:19: error: [clang-diagnostic-error]

use of undeclared identifier 'pybind11'
```
  121 |             .def( pybind11::init<>() )
      |                   ^
```
bindings/python/src/validity/brep_validity.hpp:32:32: error: [clang-diagnostic-error]

use of undeclared identifier 'pybind11'
```
   32 |     void define_brep_validity( pybind11::module& module )
      |                                ^
```

bindings/python/src/validity/edgedcurve_validity.hpp:32:39: error: [clang-diagnostic-error]

use of undeclared identifier 'pybind11'

   32 |     void define_edged_curve_validity( pybind11::module& module )
      |                                       ^

bindings/python/src/validity/object_validity.hpp:32:41: error: [clang-diagnostic-error]

use of undeclared identifier 'pybind11'

   32 |     inline void define_object_validity( pybind11::module& module )
      |                                         ^

bindings/python/src/validity/object_validity.hpp:34:9: error: [clang-diagnostic-error]

use of undeclared identifier 'pybind11'
```
   34 |         pybind11::class_< ObjectValidity >( module, "ObjectValidity" )
      |         ^
```

bindings/python/src/validity/object_validity.hpp:34:27: error: [clang-diagnostic-error]

'ObjectValidity' does not refer to a value

   34 |         pybind11::class_< ObjectValidity >( module, "ObjectValidity" )
      |                           ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/include/geode/inspector/validity/object_validity.hpp:30:45: note: declared here
   30 |     struct opengeode_inspector_validity_api ObjectValidity
      |                                             ^

bindings/python/src/validity/pointset_validity.hpp:32:37: error: [clang-diagnostic-error]

use of undeclared identifier 'pybind11'

   32 |     void define_point_set_validity( pybind11::module& module )
      |                                     ^

bindings/python/src/validity/section_validity.hpp:32:35: error: [clang-diagnostic-error]

use of undeclared identifier 'pybind11'
```
   32 |     void define_section_validity( pybind11::module& module )
      |                                   ^
```

bindings/python/src/validity/solid_validity.hpp:32:38: error: [clang-diagnostic-error]

use of undeclared identifier 'pybind11'

   32 |     void define_solid_mesh_validity( pybind11::module& module )
      |                                      ^

bindings/python/src/validity/surface_validity.hpp:32:40: error: [clang-diagnostic-error]

use of undeclared identifier 'pybind11'

   32 |     void define_surface_mesh_validity( pybind11::module& module )
      |                                        ^

include/geode/inspector/inspection/solid_inspector.hpp:84:46: warning: [cppcoreguidelines-special-member-functions]

class 'SolidMeshInspector' defines a copy constructor and a copy assignment operator but does not define a destructor, a move constructor or a move assignment operator
```
   84 |     class opengeode_inspector_inspection_api SolidMeshInspector
      |                                              ^
```
include/geode/inspector/validity/object_validity.hpp:41:48: warning: [readability-redundant-member-init]

initializer for member 'invalidities' is redundant
```
   41 |         std::vector< std::string > invalidities{};
      |                                                ^~
```

src/geode/inspector/inspection/topology/brep_corners_topology.cpp:102:31: warning: [readability-function-cognitive-complexity]

function 'brep_corner_topology_is_valid' has cognitive complexity of 14 (threshold 10)

  102 |     bool BRepCornersTopology::brep_corner_topology_is_valid(
      |                               ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:106:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  106 |         for( const auto& cmv :
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:109:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  109 |             if( cmv.component_id.type() != Corner3D::component_type_static()
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:110:17: note: +1
  110 |                 || !brep_.corner( cmv.component_id.id() ).is_active() )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:114:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  114 |             if( corner_found )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:120:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  120 |             if( brep_.nb_embeddings( corner_uuid ) == 0 )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:122:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  122 |                 if( brep_.nb_incidences( corner_uuid ) == 0 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:127:18: note: +1, nesting level increased to 2
  127 |             else if( brep_.nb_incidences( corner_uuid ) > 1 )
      |                  ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:132:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  132 |         if( corner_is_multiply_embedded( unique_vertex_index ) )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:136:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  136 |         if( corner_is_part_of_line_but_not_boundary( unique_vertex_index ) )
      |         ^

src/geode/inspector/inspection/topology/brep_corners_topology.cpp:180:30: warning: [readability-function-cognitive-complexity]

function 'corner_is_multiply_embedded' has cognitive complexity of 12 (threshold 10)

  180 |         BRepCornersTopology::corner_is_multiply_embedded(
      |                              ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:183:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  183 |         for( const auto& cmv :
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:186:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  186 |             if( cmv.component_id.type() == Corner3D::component_type_static()
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:188:17: note: +1
  188 |                 && brep_.nb_embeddings( cmv.component_id.id() ) > 1 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:190:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  190 |                 for( const auto& embedding :
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:193:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  193 |                     if( embedding.type() == Block3D::component_type_static()
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:194:25: note: +1
  194 |                         && brep_.block( embedding.id() ).is_active() )
      |                         ^

src/geode/inspector/inspection/topology/brep_corners_topology.cpp:236:30: warning: [readability-function-cognitive-complexity]

function 'corner_is_part_of_line_but_not_boundary' has cognitive complexity of 29 (threshold 10)

  236 |         BRepCornersTopology::corner_is_part_of_line_but_not_boundary(
      |                              ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:239:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  239 |         for( const auto& cmv :
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:242:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  242 |             if( cmv.component_id.type() != Corner3D::component_type_static()
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:243:17: note: +1
  243 |                 || !brep_.corner( cmv.component_id.id() ).is_active() )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:248:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  248 |             for( const auto& cmv_line :
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:251:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  251 |                 if( cmv_line.component_id.type()
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:253:21: note: +1
  253 |                     || !brep_.line( cmv_line.component_id.id() ).is_active() )
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:257:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  257 |                 if( brep_.Relationships::is_boundary(
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:262:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  262 |                 if( brep_.Relationships::is_internal(
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:266:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  266 |                     for( const auto& cmv2 :
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:269:25: note: +5, including nesting penalty of 4, nesting level increased to 5
  269 |                         if( cmv2.component_id.id() == corner_uuid )
      |                         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:274:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  274 |                     if( line_vertex_count != 2 )
      |                     ^

src/geode/inspector/inspection/topology/brep_corners_topology.cpp:311:30: warning: [readability-function-cognitive-complexity]

function 'inspect_corners_topology' has cognitive complexity of 14 (threshold 10)

  311 |         BRepCornersTopology::inspect_corners_topology() const
      |                              ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:314:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  314 |         for( const auto& corner : brep_.active_corners() )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:316:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  316 |             if( !corner_is_meshed( brep_.corner( corner.id() ) ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:327:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  327 |             if( corner_result.nb_issues() != 0 )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:336:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  336 |         for( const auto unique_vertex_id : Range{ brep_.nb_unique_vertices() } )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:338:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  338 |             if( const auto problem_message =
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:344:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  344 |             if( const auto problem_message =
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:350:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  350 |             if( const auto problem_message =
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_corners_topology.cpp:357:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  357 |             if( const auto problem_message =
      |             ^

tests/inspection/test-brep.cpp:34:16: warning: [misc-use-internal-linkage]

function 'corners_topological_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   34 | geode::index_t corners_topological_validity(
      |                ^
      | static 
```
tests/inspection/test-brep.cpp:62:16: warning: [misc-use-internal-linkage]

function 'lines_topological_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   62 | geode::index_t lines_topological_validity(
      |                ^
      | static 
```
tests/inspection/test-brep.cpp:93:16: warning: [misc-use-internal-linkage]

function 'surfaces_topological_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   93 | geode::index_t surfaces_topological_validity(
      |                ^
      | static 
```
tests/inspection/test-brep.cpp:122:16: warning: [misc-use-internal-linkage]

function 'blocks_topological_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  122 | geode::index_t blocks_topological_validity(
      |                ^
      | static 
```
tests/inspection/test-brep.cpp:157:16: warning: [misc-use-internal-linkage]

function 'launch_topological_validity_checks' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  157 | geode::index_t launch_topological_validity_checks(
      |                ^
      | static 
```
tests/inspection/test-brep.cpp:167:16: warning: [misc-use-internal-linkage]

function 'meshes_adjacencies_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  167 | geode::index_t meshes_adjacencies_validity(
      |                ^
      | static 
```
tests/inspection/test-brep.cpp:190:16: warning: [misc-use-internal-linkage]

function 'meshes_degenerations_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  190 | geode::index_t meshes_degenerations_validity(
      |                ^
      | static 
```
tests/inspection/test-brep.cpp:218:16: warning: [misc-use-internal-linkage]

function 'meshes_intersections_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  218 | geode::index_t meshes_intersections_validity(
      |                ^
      | static 
```

tests/inspection/test-brep.cpp:219:56: warning: [performance-unnecessary-value-param]

the const qualified parameter 'result' is copied for each invocation; consider making it a reference

  219 |     const geode::ElementsIntersectionsInspectionResult result, bool string )
      |                                                        ^
      |                                                       &

tests/inspection/test-brep.cpp:233:16: warning: [misc-use-internal-linkage]

function 'meshes_manifolds_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  233 | geode::index_t meshes_manifolds_validity(
      |                ^
      | static 
```
tests/inspection/test-brep.cpp:262:16: warning: [misc-use-internal-linkage]

function 'meshes_colocations_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  262 | geode::index_t meshes_colocations_validity(
      |                ^
      | static 
```
tests/inspection/test-brep.cpp:279:16: warning: [misc-use-internal-linkage]

function 'meshes_unique_vertices_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  279 | geode::index_t meshes_unique_vertices_validity(
      |                ^
      | static 
```
tests/inspection/test-brep.cpp:298:16: warning: [misc-use-internal-linkage]

function 'launch_component_meshes_validity_checks' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  298 | geode::index_t launch_component_meshes_validity_checks(
      |                ^
      | static 
```

tests/inspection/test-brep.cpp:301:10: warning: [clang-analyzer-deadcode.DeadStores]

Value stored to 'nb_issues' during its initialization is never read

  301 |     auto nb_issues =
      |          ^~~~~~~~~
  302 |         meshes_adjacencies_validity( result.meshes_adjacencies, string );
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/OpenGeode-Inspector/OpenGeode-Inspector/tests/inspection/test-brep.cpp:301:10: note: Value stored to 'nb_issues' during its initialization is never read
  301 |     auto nb_issues =
      |          ^~~~~~~~~
  302 |         meshes_adjacencies_validity( result.meshes_adjacencies, string );
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/inspection/test-brep.cpp:316:6: warning: [misc-use-internal-linkage]

function 'check_model_a1' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  316 | void check_model_a1( bool string )
      |      ^
      | static 
```
tests/inspection/test-brep.cpp:329:34: warning: [cppcoreguidelines-avoid-magic-numbers]

5201 is a magic number; consider replacing it with a named constant
```
  329 |         nb_topological_issues == 5201, "model_A1 has ", nb_topological_issues,
      |                                  ^
```
tests/inspection/test-brep.cpp:335:39: warning: [cppcoreguidelines-avoid-magic-numbers]

13494 is a magic number; consider replacing it with a named constant
```
  335 |         nb_component_meshes_issues == 13494, "model_A1 has ",
      |                                       ^
```
tests/inspection/test-brep.cpp:339:6: warning: [misc-use-internal-linkage]

function 'check_model_a1_valid' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  339 | void check_model_a1_valid( bool string )
      |      ^
      | static 
```
tests/inspection/test-brep.cpp:352:34: warning: [cppcoreguidelines-avoid-magic-numbers]

5201 is a magic number; consider replacing it with a named constant
```
  352 |         nb_topological_issues == 5201, "model_A1_valid has ",
      |                                  ^
```
tests/inspection/test-brep.cpp:358:39: warning: [cppcoreguidelines-avoid-magic-numbers]

13494 is a magic number; consider replacing it with a named constant
```
  358 |         nb_component_meshes_issues == 13494, "model_A1_valid has ",
      |                                       ^
```
tests/inspection/test-brep.cpp:362:6: warning: [misc-use-internal-linkage]

function 'check_model_mss' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  362 | void check_model_mss( bool string )
      |      ^
      | static 
```
tests/inspection/test-brep.cpp:375:34: warning: [cppcoreguidelines-avoid-magic-numbers]

52 is a magic number; consider replacing it with a named constant
```
  375 |         nb_topological_issues == 52, "mss has ", nb_topological_issues,
      |                                  ^
```
tests/inspection/test-brep.cpp:385:6: warning: [misc-use-internal-linkage]

function 'check_model_D' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  385 | void check_model_D( bool string )
      |      ^
      | static 
```
tests/inspection/test-brep.cpp:385:6: warning: [readability-identifier-naming]

invalid case style for global function 'check_model_D'
```
  385 | void check_model_D( bool string )
      |      ^~~~~~~~~~~~~
      |      check_model_d
```
tests/inspection/test-brep.cpp:406:6: warning: [misc-use-internal-linkage]

function 'check_wrong_bsurfaces_model' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  406 | void check_wrong_bsurfaces_model()
      |      ^
      | static 
```
tests/inspection/test-brep.cpp:433:6: warning: [misc-use-internal-linkage]

function 'check_segmented_cube' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  433 | void check_segmented_cube()
      |      ^
      | static 
```

tests/inspection/test-brep.cpp:443:16: warning: [clang-analyzer-deadcode.DeadStores]

Value stored to 'nb_component_meshes_issues' during its initialization is never read

  443 |     const auto nb_component_meshes_issues =
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~
  444 |         launch_component_meshes_validity_checks( result.meshes, false );
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/OpenGeode-Inspector/OpenGeode-Inspector/tests/inspection/test-brep.cpp:443:16: note: Value stored to 'nb_component_meshes_issues' during its initialization is never read
  443 |     const auto nb_component_meshes_issues =
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~
  444 |         launch_component_meshes_validity_checks( result.meshes, false );
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/inspection/test-section.cpp:36:16: warning: [misc-use-internal-linkage]

function 'corners_topological_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   36 | geode::index_t corners_topological_validity(
      |                ^
      | static 
```
tests/inspection/test-section.cpp:64:16: warning: [misc-use-internal-linkage]

function 'lines_topological_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   64 | geode::index_t lines_topological_validity(
      |                ^
      | static 
```
tests/inspection/test-section.cpp:94:16: warning: [misc-use-internal-linkage]

function 'surfaces_topological_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   94 | geode::index_t surfaces_topological_validity(
      |                ^
      | static 
```
tests/inspection/test-section.cpp:119:16: warning: [misc-use-internal-linkage]

function 'launch_topological_validity_checks' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  119 | geode::index_t launch_topological_validity_checks(
      |                ^
      | static 
```
tests/inspection/test-section.cpp:128:16: warning: [misc-use-internal-linkage]

function 'meshes_adjacencies_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  128 | geode::index_t meshes_adjacencies_validity(
      |                ^
      | static 
```
tests/inspection/test-section.cpp:146:16: warning: [misc-use-internal-linkage]

function 'meshes_degenerations_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  146 | geode::index_t meshes_degenerations_validity(
      |                ^
      | static 
```
tests/inspection/test-section.cpp:170:16: warning: [misc-use-internal-linkage]

function 'meshes_intersections_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  170 | geode::index_t meshes_intersections_validity(
      |                ^
      | static 
```

tests/inspection/test-section.cpp:171:56: warning: [performance-unnecessary-value-param]

the const qualified parameter 'result' is copied for each invocation; consider making it a reference

  171 |     const geode::ElementsIntersectionsInspectionResult result, bool string )
      |                                                        ^
      |                                                       &

tests/inspection/test-section.cpp:185:16: warning: [misc-use-internal-linkage]

function 'meshes_manifolds_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  185 | geode::index_t meshes_manifolds_validity(
      |                ^
      | static 
```
tests/inspection/test-section.cpp:206:16: warning: [misc-use-internal-linkage]

function 'meshes_colocations_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  206 | geode::index_t meshes_colocations_validity(
      |                ^
      | static 
```
tests/inspection/test-section.cpp:223:16: warning: [misc-use-internal-linkage]

function 'meshes_unique_vertices_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  223 | geode::index_t meshes_unique_vertices_validity(
      |                ^
      | static 
```
tests/inspection/test-section.cpp:242:16: warning: [misc-use-internal-linkage]

function 'launch_component_meshes_validity_checks' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  242 | geode::index_t launch_component_meshes_validity_checks(
      |                ^
      | static 
```

tests/inspection/test-section.cpp:245:10: warning: [clang-analyzer-deadcode.DeadStores]

Value stored to 'nb_issues' during its initialization is never read

  245 |     auto nb_issues =
      |          ^~~~~~~~~
  246 |         meshes_adjacencies_validity( result.meshes_adjacencies, string );
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/OpenGeode-Inspector/OpenGeode-Inspector/tests/inspection/test-section.cpp:245:10: note: Value stored to 'nb_issues' during its initialization is never read
  245 |     auto nb_issues =
      |          ^~~~~~~~~
  246 |         meshes_adjacencies_validity( result.meshes_adjacencies, string );
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/inspection/test-section.cpp:260:6: warning: [misc-use-internal-linkage]

function 'check_section' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  260 | void check_section( bool string )
      |      ^
      | static 
```
tests/inspection/test-section.cpp:283:6: warning: [misc-use-internal-linkage]

function 'check_section_test' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  283 | void check_section_test()
      |      ^
      | static 
```
tests/validity/test-brep-validity.cpp:34:6: warning: [misc-use-internal-linkage]

function 'check_model_a1' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   34 | void check_model_a1()
      |      ^
      | static 
```
tests/validity/test-brep-validity.cpp:41:37: warning: [cppcoreguidelines-avoid-magic-numbers]

7 is a magic number; consider replacing it with a named constant
```
   41 |         invalidities.nb_issues() == 7, "model_A1 has ",
      |                                     ^
```
tests/validity/test-brep-validity.cpp:45:6: warning: [misc-use-internal-linkage]

function 'check_model_a1_valid' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   45 | void check_model_a1_valid()
      |      ^
      | static 
```
tests/validity/test-brep-validity.cpp:52:37: warning: [cppcoreguidelines-avoid-magic-numbers]

7 is a magic number; consider replacing it with a named constant
```
   52 |         invalidities.nb_issues() == 7, "model_A1_valid has ",
      |                                     ^
```
tests/validity/test-brep-validity.cpp:56:6: warning: [misc-use-internal-linkage]

function 'check_model_mss' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   56 | void check_model_mss()
      |      ^
      | static 
```
tests/validity/test-brep-validity.cpp:63:37: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant
```
   63 |         invalidities.nb_issues() == 5, "model_mss has ",
      |                                     ^
```
tests/validity/test-brep-validity.cpp:67:6: warning: [misc-use-internal-linkage]

function 'check_model_D' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   67 | void check_model_D()
      |      ^
      | static 
```
tests/validity/test-brep-validity.cpp:67:6: warning: [readability-identifier-naming]

invalid case style for global function 'check_model_D'
```
   67 | void check_model_D()
      |      ^~~~~~~~~~~~~
      |      check_model_d
```
tests/validity/test-brep-validity.cpp:78:6: warning: [misc-use-internal-linkage]

function 'check_wrong_bsurfaces_model' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   78 | void check_wrong_bsurfaces_model()
      |      ^
      | static 
```
tests/validity/test-brep-validity.cpp:89:6: warning: [misc-use-internal-linkage]

function 'check_segmented_cube' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   89 | void check_segmented_cube()
      |      ^
      | static 
```
tests/validity/test-edgedcurve-validity.cpp:34:6: warning: [misc-use-internal-linkage]

function 'check_invalidity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   34 | void check_invalidity()
      |      ^
      | static 
```
tests/validity/test-edgedcurve-validity.cpp:38:31: warning: [cppcoreguidelines-avoid-magic-numbers]

7 is a magic number; consider replacing it with a named constant
```
   38 |     builder->create_vertices( 7 );
      |                               ^
```
tests/validity/test-edgedcurve-validity.cpp:39:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   39 |     builder->set_point( 0, geode::Point3D{ { 0., 2., 1. } } );
      |                                                  ^
```
tests/validity/test-edgedcurve-validity.cpp:40:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   40 |     builder->set_point( 1, geode::Point3D{ { 0., 2., 1. } } );
      |                                                  ^
```
tests/validity/test-edgedcurve-validity.cpp:42:46: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   42 |     builder->set_point( 3, geode::Point3D{ { 2., 0., 0. } } );
      |                                              ^
```
tests/validity/test-edgedcurve-validity.cpp:43:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   43 |     builder->set_point( 4, geode::Point3D{ { 1., 4., 3. } } );
      |                                                  ^
```
tests/validity/test-edgedcurve-validity.cpp:43:54: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   43 |     builder->set_point( 4, geode::Point3D{ { 1., 4., 3. } } );
      |                                                      ^
```
tests/validity/test-edgedcurve-validity.cpp:44:25: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant
```
   44 |     builder->set_point( 5, geode::Point3D{ { 2., geode::GLOBAL_EPSILON / 2,
      |                         ^
```
tests/validity/test-edgedcurve-validity.cpp:44:46: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   44 |     builder->set_point( 5, geode::Point3D{ { 2., geode::GLOBAL_EPSILON / 2,
      |                                              ^
```
tests/validity/test-edgedcurve-validity.cpp:47:9: warning: [cppcoreguidelines-avoid-magic-numbers]

6 is a magic number; consider replacing it with a named constant
```
   47 |         6, geode::Point3D{ { geode::GLOBAL_EPSILON / 1.1, 2., 1. } } );
      |         ^
```
tests/validity/test-edgedcurve-validity.cpp:47:54: warning: [cppcoreguidelines-avoid-magic-numbers]

1.1 is a magic number; consider replacing it with a named constant
```
   47 |         6, geode::Point3D{ { geode::GLOBAL_EPSILON / 1.1, 2., 1. } } );
      |                                                      ^
```

tests/validity/test-edgedcurve-validity.cpp:47:59: warning: [cppcoreguidelines-avoid-magic-numbers]

is a magic number; consider replacing it with a named constant

   47 |         6, geode::Point3D{ { geode::GLOBAL_EPSILON / 1.1, 2., 1. } } );
      |                                                           ^

tests/validity/test-edgedcurve-validity.cpp:60:30: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant
```
   60 |     builder->create_edge( 4, 5 );
      |                              ^
```
tests/validity/test-edgedcurve-validity.cpp:61:27: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant
```
   61 |     builder->create_edge( 5, 6 );
      |                           ^
```
tests/validity/test-edgedcurve-validity.cpp:61:30: warning: [cppcoreguidelines-avoid-magic-numbers]

6 is a magic number; consider replacing it with a named constant
```
   61 |     builder->create_edge( 5, 6 );
      |                              ^
```
tests/validity/test-pointset-validity.cpp:34:6: warning: [misc-use-internal-linkage]

function 'check_non_validity2D' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   34 | void check_non_validity2D()
      |      ^
      | static 
```
tests/validity/test-pointset-validity.cpp:34:6: warning: [readability-identifier-naming]

invalid case style for global function 'check_non_validity2D'
```
   34 | void check_non_validity2D()
      |      ^~~~~~~~~~~~~~~~~~~~
      |      check_non_validity2_d
```
tests/validity/test-pointset-validity.cpp:39:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   39 |     builder->set_point( 0, geode::Point2D{ { 0., 2. } } );
      |                                                  ^
```
tests/validity/test-pointset-validity.cpp:40:46: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   40 |     builder->set_point( 1, geode::Point2D{ { 2., 0. } } );
      |                                              ^
```
tests/validity/test-pointset-validity.cpp:41:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   41 |     builder->set_point( 2, geode::Point2D{ { 1., 4. } } );
      |                                                  ^
```
tests/validity/test-pointset-validity.cpp:42:46: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   42 |     builder->set_point( 3, geode::Point2D{ { 3., 3. } } );
      |                                              ^
```
tests/validity/test-pointset-validity.cpp:42:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   42 |     builder->set_point( 3, geode::Point2D{ { 3., 3. } } );
      |                                                  ^
```
tests/validity/test-pointset-validity.cpp:51:6: warning: [misc-use-internal-linkage]

function 'check_validity2D' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   51 | void check_validity2D()
      |      ^
      | static 
```
tests/validity/test-pointset-validity.cpp:51:6: warning: [readability-identifier-naming]

invalid case style for global function 'check_validity2D'
```
   51 | void check_validity2D()
      |      ^~~~~~~~~~~~~~~~
      |      check_validity2_d
```
tests/validity/test-pointset-validity.cpp:55:31: warning: [cppcoreguidelines-avoid-magic-numbers]

7 is a magic number; consider replacing it with a named constant
```
   55 |     builder->create_vertices( 7 );
      |                               ^
```
tests/validity/test-pointset-validity.cpp:56:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   56 |     builder->set_point( 0, geode::Point2D{ { 0., 2. } } );
      |                                                  ^
```
tests/validity/test-pointset-validity.cpp:57:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   57 |     builder->set_point( 1, geode::Point2D{ { 0., 2. } } );
      |                                                  ^
```
tests/validity/test-pointset-validity.cpp:59:46: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   59 |     builder->set_point( 3, geode::Point2D{ { 2., 0. } } );
      |                                              ^
```
tests/validity/test-pointset-validity.cpp:60:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   60 |     builder->set_point( 4, geode::Point2D{ { 1., 4. } } );
      |                                                  ^
```
tests/validity/test-pointset-validity.cpp:62:9: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant
```
   62 |         5, geode::Point2D{ { 2., geode::GLOBAL_EPSILON / 2 } } );
      |         ^
```
tests/validity/test-pointset-validity.cpp:62:30: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   62 |         5, geode::Point2D{ { 2., geode::GLOBAL_EPSILON / 2 } } );
      |                              ^
```
tests/validity/test-pointset-validity.cpp:64:9: warning: [cppcoreguidelines-avoid-magic-numbers]

6 is a magic number; consider replacing it with a named constant
```
   64 |         6, geode::Point2D{ { geode::GLOBAL_EPSILON / 1.1, 2. } } );
      |         ^
```
tests/validity/test-pointset-validity.cpp:64:54: warning: [cppcoreguidelines-avoid-magic-numbers]

1.1 is a magic number; consider replacing it with a named constant
```
   64 |         6, geode::Point2D{ { geode::GLOBAL_EPSILON / 1.1, 2. } } );
      |                                                      ^
```

tests/validity/test-pointset-validity.cpp:64:59: warning: [cppcoreguidelines-avoid-magic-numbers]

is a magic number; consider replacing it with a named constant

   64 |         6, geode::Point2D{ { geode::GLOBAL_EPSILON / 1.1, 2. } } );
      |                                                           ^

tests/validity/test-pointset-validity.cpp:74:6: warning: [misc-use-internal-linkage]

function 'check_non_validity3D' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   74 | void check_non_validity3D()
      |      ^
      | static 
```
tests/validity/test-pointset-validity.cpp:74:6: warning: [readability-identifier-naming]

invalid case style for global function 'check_non_validity3D'
```
   74 | void check_non_validity3D()
      |      ^~~~~~~~~~~~~~~~~~~~
      |      check_non_validity3_d
```
tests/validity/test-pointset-validity.cpp:79:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   79 |     builder->set_point( 0, geode::Point3D{ { 0., 2., 0. } } );
      |                                                  ^
```
tests/validity/test-pointset-validity.cpp:80:46: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   80 |     builder->set_point( 1, geode::Point3D{ { 2., 0., 0.5 } } );
      |                                              ^
```
tests/validity/test-pointset-validity.cpp:80:54: warning: [cppcoreguidelines-avoid-magic-numbers]

0.5 is a magic number; consider replacing it with a named constant
```
   80 |     builder->set_point( 1, geode::Point3D{ { 2., 0., 0.5 } } );
      |                                                      ^
```
tests/validity/test-pointset-validity.cpp:81:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   81 |     builder->set_point( 2, geode::Point3D{ { 1., 4., 1. } } );
      |                                                  ^
```
tests/validity/test-pointset-validity.cpp:82:46: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   82 |     builder->set_point( 3, geode::Point3D{ { 3., 3., 2. } } );
      |                                              ^
```
tests/validity/test-pointset-validity.cpp:82:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   82 |     builder->set_point( 3, geode::Point3D{ { 3., 3., 2. } } );
      |                                                  ^
```
tests/validity/test-pointset-validity.cpp:82:54: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   82 |     builder->set_point( 3, geode::Point3D{ { 3., 3., 2. } } );
      |                                                      ^
```
tests/validity/test-pointset-validity.cpp:91:6: warning: [misc-use-internal-linkage]

function 'check_validity3D' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   91 | void check_validity3D()
      |      ^
      | static 
```
tests/validity/test-pointset-validity.cpp:91:6: warning: [readability-identifier-naming]

invalid case style for global function 'check_validity3D'
```
   91 | void check_validity3D()
      |      ^~~~~~~~~~~~~~~~
      |      check_validity3_d
```
tests/validity/test-pointset-validity.cpp:95:31: warning: [cppcoreguidelines-avoid-magic-numbers]

7 is a magic number; consider replacing it with a named constant
```
   95 |     builder->create_vertices( 7 );
      |                               ^
```
tests/validity/test-pointset-validity.cpp:96:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   96 |     builder->set_point( 0, geode::Point3D{ { 0., 2., 1. } } );
      |                                                  ^
```
tests/validity/test-pointset-validity.cpp:97:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   97 |     builder->set_point( 1, geode::Point3D{ { 0., 2., 1. } } );
      |                                                  ^
```
tests/validity/test-pointset-validity.cpp:99:46: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   99 |     builder->set_point( 3, geode::Point3D{ { 2., 0., 0. } } );
      |                                              ^
```
tests/validity/test-pointset-validity.cpp:100:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
  100 |     builder->set_point( 4, geode::Point3D{ { 1., 4., 3. } } );
      |                                                  ^
```
tests/validity/test-pointset-validity.cpp:100:54: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
  100 |     builder->set_point( 4, geode::Point3D{ { 1., 4., 3. } } );
      |                                                      ^
```
tests/validity/test-pointset-validity.cpp:101:25: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant
```
  101 |     builder->set_point( 5, geode::Point3D{ { 2., geode::GLOBAL_EPSILON / 2,
      |                         ^
```

Have any feedback or feature suggestions? Share it here.

BotellaA · 2026-06-09T14:07:29Z

🎉 This PR is included in version 6.10.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

BotellaA · 2026-06-11T01:18:10Z

🎉 This PR is included in version 6.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

feat(Validity): Added validity checks for all meshes

a9fa7ab

MelchiorSchuh requested a review from BotellaA June 5, 2026 10:45

BotellaA approved these changes Jun 5, 2026

View reviewed changes

Comment thread include/geode/inspector/validity/surface_validity.hpp Outdated

panquez approved these changes Jun 5, 2026

View reviewed changes

Comment thread src/geode/inspector/inspection/criterion/manifold/surface_vertex_manifold.cpp Outdated

MelchiorSchuh added 5 commits June 8, 2026 15:24

arnaud comments and python tests

5f058c8

Added model validity functions

6c09886

added model python bindings

addd853

feat(Validity): Added validity checks for models

cabceaf

fix test

f6d60ae

BotellaA merged commit 544d88a into next Jun 9, 2026
20 checks passed

BotellaA deleted the feat/meshes_validity branch June 9, 2026 13:57

BotellaA added the released on @next label Jun 9, 2026

BotellaA added the released label Jun 11, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Validity): Added validity checks for all meshes#179

feat(Validity): Added validity checks for all meshes#179
BotellaA merged 6 commits into
nextfrom
feat/meshes_validity

MelchiorSchuh commented Jun 5, 2026

Uh oh!

github-actions Bot commented Jun 5, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BotellaA commented Jun 9, 2026

Uh oh!

BotellaA commented Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

MelchiorSchuh commented Jun 5, 2026

Uh oh!

github-actions Bot commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Cpp-Linter Report ⚠️

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BotellaA commented Jun 9, 2026

Uh oh!

BotellaA commented Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jun 5, 2026 •

edited

Loading