Skip to content

fix(VTIOutput): Added missing include - #194

Merged
BotellaA merged 1 commit into
nextfrom
fix/missing_include_in_vti_output
Jul 29, 2026
Merged

fix(VTIOutput): Added missing include#194
BotellaA merged 1 commit into
nextfrom
fix/missing_include_in_vti_output

Conversation

@MelchiorSchuh

Copy link
Copy Markdown
Member

No description provided.

@MelchiorSchuh
MelchiorSchuh requested a review from BotellaA July 29, 2026 08:46
@github-actions

Copy link
Copy Markdown

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 3 concern(s)
  • include/geode/io/mesh/detail/vti_grid_output.hpp:34:1: warning: [modernize-concat-nested-namespaces]

    nested namespaces can be concatenated

       34 | namespace geode
          | ^~~~~~~~~~~~~~~
       35 | {
          | ~
       36 |     namespace detail
          |     ~~~~~~~~~~~~~~~~
          |     namespace geode::detail
  • include/geode/io/mesh/detail/vti_grid_output.hpp:63:18: warning: [readability-function-cognitive-complexity]

    function 'write_header' has cognitive complexity of 11 (threshold 10)

       63 |             void write_header( pugi::xml_node& header_node )
          |                  ^
    /__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/mesh/detail/vti_grid_output.hpp:70:17: note: +1, including nesting penalty of 0, nesting level increased to 1
       70 |                 if( dimension == 2 )
          |                 ^
    /__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/mesh/detail/vti_grid_output.hpp:77:17: note: +1, including nesting penalty of 0, nesting level increased to 1
       77 |                 for( const auto d : LRange{ dimension } )
          |                 ^
    /__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/mesh/detail/vti_grid_output.hpp:79:21: note: +2, including nesting penalty of 1, nesting level increased to 2
       79 |                     if( d != 0 )
          |                     ^
    /__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/mesh/detail/vti_grid_output.hpp:86:17: note: +1, including nesting penalty of 0, nesting level increased to 1
       86 |                 if( dimension == 2 )
          |                 ^
    /__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/mesh/detail/vti_grid_output.hpp:93:17: note: +1, including nesting penalty of 0, nesting level increased to 1
       93 |                 for( const auto d1 : LRange{ dimension } )
          |                 ^
    /__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/mesh/detail/vti_grid_output.hpp:95:21: note: +2, including nesting penalty of 1, nesting level increased to 2
       95 |                     if( d1 != 0 )
          |                     ^
    /__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/mesh/detail/vti_grid_output.hpp:102:21: note: +2, including nesting penalty of 1, nesting level increased to 2
      102 |                     if( dimension == 2 )
          |                     ^
    /__w/OpenGeode-IO/OpenGeode-IO/include/geode/io/mesh/detail/vti_grid_output.hpp:107:17: note: +1, including nesting penalty of 0, nesting level increased to 1
      107 |                 if( dimension == 2 )
          |                 ^
  • include/geode/io/mesh/detail/vti_grid_output.hpp:93:33: warning: [readability-identifier-length]

    variable name 'd1' is too short, expected at least 3 characters

       93 |                 for( const auto d1 : LRange{ dimension } )
          |                                 ^

Have any feedback or feature suggestions? Share it here.

@BotellaA
BotellaA merged commit e2e91e9 into next Jul 29, 2026
19 checks passed
@BotellaA
BotellaA deleted the fix/missing_include_in_vti_output branch July 29, 2026 09:25
@BotellaA

Copy link
Copy Markdown
Member

🎉 This PR is included in version 7.7.2-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA

Copy link
Copy Markdown
Member

🎉 This PR is included in version 7.7.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants