Skip to content

fix: regex should not be required - #415

Merged
wilsonjord merged 2 commits into
mainfrom
feat-make-regex-optional
Oct 19, 2026
Merged

wilsonjord merged 2 commits into
mainfrom
feat-make-regex-optional

Conversation

@wilsonjord

Copy link
Copy Markdown
Contributor

Shouldn't need to specify regex for container cleanup, as a user can decided on a "keep 10 last images" type approach instead.

@wilsonjord
wilsonjord requested a review from a team as a code owner October 18, 2026 21:44
This workflow is a thin wrapper around `delete-package-versions`.
Use of regex input should reflect the varible it wraps (`ignore-versions` is optional).
@wilsonjord
wilsonjord force-pushed the feat-make-regex-optional branch from 485ed99 to 28fbbb0 Compare October 18, 2026 21:50
@wilsonjord
wilsonjord requested a review from jajera October 18, 2026 21:54
@jajera

jajera commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Shouldn't need to specify regex for container cleanup, as a user can decided on a "keep 10 last images" type approach instead.

@wilsonjord can you share where the mechanism related to container cleanup? basically, i just wanted to know more about what will change if regex is not set.

@wilsonjord

Copy link
Copy Markdown
Contributor Author

@jajera The regex can be used to specify packages to "ignore" from the deletion rules you setup. If you have no packages/images you want to exclude/ignore, then you simply don't set it.

@jajera jajera left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sensible to be optional.

@wilsonjord
wilsonjord merged commit 4b15aa5 into main Oct 19, 2026
16 checks passed
@wilsonjord
wilsonjord deleted the feat-make-regex-optional branch October 19, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants