Figure.set_panel: Fix the bug when panel is not set#4628
Open
Figure.set_panel: Fix the bug when panel is not set#4628
Conversation
bcd0848 to
787c461
Compare
787c461 to
380753f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the GMT CLI, using
gmt subplot setwithout specifying the panel activates the next panel. For example:The equivalent PyGMT script is:
But it doesn't work as expected:
The bug is because we always pass
paneltogmt subplot seteven if it'sNone. The bug can be traced back to the initial implementation in PR #822.This PR fixes the long-term bug and add a test for it.