Conversation
Directory listing for ds.iris.edu/files/sac-manual/ is now disabled (403), but the index.html inside it still works. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
joa-quim
approved these changes
Sep 15, 2026
Esteban82
added a commit
that referenced
this pull request
Sep 16, 2026
PR #9194 gated build.yml/tests.yml's matrix jobs with a job-level if: so a skip still posts a status, satisfying branch protection. That works for single-job workflows (code-validator.yml), but not for a matrix job: GitHub only expands ${{ matrix.name }} into per-leg checks ("Linux", "macOS", "Windows", "Linux (without optional dependencies)") when the job's own if: is true. When it's false, the job is skipped before the matrix is expanded, and GitHub posts one bogus status literally named "matrix.name"/"matrix.image" instead. Branch protection requires the real per-leg names, so on a documentation-only PR they never receive any status and stay "Expected - Waiting for status to be reported" forever, permanently blocking merge (confirmed live on PR #9211, a one-line doc fix). Add a twin job per workflow (build-skip, test-skip) covering the same matrix under the exact opposite condition. Since its own if: is true whenever the real job is skipped, its matrix does expand normally, so each leg reports a fast, real, successful status under the correct name. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SAC User Manual link flagged in #9205 broke.
I replaced the link with this: https://ds.iris.edu/files/sac-manual/index.html
Refs #9205
🤖 Generated with Claude Code