Pin velo vector scale to explicit cm unit in geodesy_08 test - #9207
Merged
Merged
Conversation
#9092 fixed gmt movie to correctly propagate the top directory's gmt.conf into each frame before "gmt begin" runs. As a side effect, movie frames now inherit PROJ_LENGTH_UNIT from the test harness's gmt.conf (inch) instead of silently falling back to GMT's SI default (cm). The velo scale in "-Se0.50/0" had no explicit unit, so it now resolves against the wrong default and renders vectors ~2.5x too long, same class of issue already patched for trajectory2/3/5 in #9092 itself. Fixes #9204
joa-quim
reviewed
Sep 14, 2026
joa-quim
left a comment
joa-quim
left a comment
Member
There was a problem hiding this comment.
Hmm, I guess I don't understand this. both -Se0.50c/0 and -Se0.50/0 should give the same result (default units in GMT is cm). If it doesn't, that sounds like it is hiding a more serious issue.
Member
Author
|
This is Claude's response: GMT's own default is cm, but the test harness overrides it: |
Member
Author
|
-Du stands for US units, so that's why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9092 fixed gmt movie to correctly propagate the top directory's gmt.conf into each frame before "gmt begin" runs. As a side effect, movie frames now inherit PROJ_LENGTH_UNIT from the test harness's gmt.conf (inch) instead of silently falling back to GMT's SI default (cm). The velo scale in "-Se0.50/0" had no explicit unit, so it now resolves against the wrong default and renders vectors ~2.5x too long, same class of issue already patched for trajectory2/3/5 in #9092 itself.
Fixes #9204
Done with Claude Sonnet 5.