HTTP is deprecated. Must use HTTPS.#37
Open
Meekohi wants to merge 1 commit intoGeneralScripting:masterfrom
Open
HTTP is deprecated. Must use HTTPS.#37Meekohi wants to merge 1 commit intoGeneralScripting:masterfrom
Meekohi wants to merge 1 commit intoGeneralScripting:masterfrom
Conversation
Contributor
Author
|
@jeanmartin fairly urgent merge. Library is broken without this change as of May 11, 2015. |
Contributor
Author
|
... how did the coverage go down 7% by changing one line? ;D |
Contributor
Author
|
I've had someone contact me directly who wants this PR merged. I've personally been using my fork without issue for a while now. @jeanmartin? @jufemaiz? |
Contributor
|
Looks good to me! |
Contributor
|
I don't have write access. |
Contributor
|
@GeneralScripting can you please resolve this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://blog.pipedrive.com/2015/04/deprecating-http-non-secure-api-access-from-may-11-2015/
I especially like the part where they didn't e-mail me to let me know before it broke! 👎