fix(loudness): crossfade the ad bed's loop join - #859
Merged
Merged
Conversation
aloop spliced a short bed's end straight onto its start, an audible stutter under most ads (5 of 7 gw-first-beds are under 25 s). The bed is now laid out as overlapping copies with a 0.5 s equal-power (qsin) fade at each join (asplit + afade + adelay + amix; acrossfade over asplit taps corrupts length on ffmpeg 7.1). A bed that already covers the spot renders with no split at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #855
🐛 What
Short background music under an ad no longer stutters where it repeats. Instead of a hard splice (
aloop), the music is laid out as overlapping copies with a 0.5 s equal-power fade at each join. A clip long enough for the whole ad isn't split at all.✅ Proof
Category!=Integration), plus the 9 new/updatedBedLoopJoinIsCrossfadedfacts including two real-ffmpeg ones.POST /api/ads/{id}/previewon the container's ffmpeg 6.1.1.👂 Still owed
Dean's ear check on a re-rendered demo ad (after #854 ships).