fix(core): speak and police "(555) 0142" phone shapes - #857
Merged
Merged
Conversation
PhoneShape missed a parenthesised exchange followed by four digits, so
"(555) 0142" aired as two cardinals and skipped the 555 rule. Adds a
\(\d{3}\)[-.\s]?\d{4}\b alternative to PhoneShape and the same shape to
AdScriptWriter's hygiene pattern, so a sponsor with a phone on file gets
the rewrite instead of a validator refusal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #856
🐛 What
(555) 0142,(555)-0142,(555).0142and(555)0142now matchPhoneShape:AdScriptWriter), so a sponsor with a phone on file gets the rewrite, not a refusal✅ Proof
dotnet test GenWave.sln --filter "Category!=Integration"); Ads 238, Tts 937, Core 194, Host 3177.POST /api/ads/{id}/preview; Kokoro gotcall five five five, zero one four two today!.(2026) 1234stay untouched.(100) 2026now reads as a phone, same as100 2026already did.