data_validation: point the agentdataflow central schema at the dataset-local one - #73
Open
gautamgb wants to merge 1 commit into
Conversation
…t-local one GenAI-Security-Project#62 settled the direction: dataset-local schemas are authoritative, the central data_validation/schemas/*.json are historical stubs. This is the follow-up promised there for agentdataflow_trace.schema.json specifically. The file becomes a $ref into datasets/agentdataflow_toolexchange_traces/schema.json, with a $comment naming the concrete divergences (trace_id shape, typed spans instead of an untyped array, the disposition enum, required provenance evidence) and pointing at GenAI-Security-Project#62 for why each one is deliberate. Nothing in the codebase currently loads or validates against this file - grepped for both "agentdataflow_trace.schema.json" and "exploit.schema.json" across .py, .md, and .yml and found no reference - so this is a documentation fix, not a behavior change, and there is nothing to test beyond the file parsing as JSON, which it does. The same drift exists between datasets/exploit_dataset/schema.json and data_validation/schemas/exploit.schema.json; filed as a separate issue rather than fixed here, since it's a different dataset's call to make and this PR should stay reviewable as one change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The other follow-up from #62's review:
data_validation/schemas/agentdataflow_trace.schema.jsonbecomes a pointer into the dataset-local schema atdatasets/agentdataflow_toolexchange_traces/schema.json, which is now authoritative.The file becomes a
$refinto the dataset-local schema, with a$commentnaming the concrete divergences (trace_idshape, typedspansinstead of an untyped array, thedispositionenum admitting an unintentional failure, requiredprovenanceevidence) and pointing at #62 for the reasoning behind each one.Checked before touching anything: nothing in the codebase currently loads or validates against either central stub. Grepped
.py,.md, and.ymlrepo-wide foragentdataflow_trace.schema.jsonandexploit.schema.jsonand found no reference to either. So this is a documentation correction, not a behavior change - there's nothing to test beyond the file parsing as JSON, which it does.The same drift exists between
datasets/exploit_dataset/schema.jsonanddata_validation/schemas/exploit.schema.json- all 59 current entries fail the central stub. Filed separately as an issue rather than fixed here, since it's a different dataset and a different owner's call.