v0.5.0: Tune estimated thresholds via accuracy search#4
Merged
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Replace Overflow error with silent saturation for total functions (exp, pow2, sinh, cosh, tan). Fix sin/cos to handle extreme angles via direct quotient computation. Tune Taylor thresholds for improved accuracy.
52c3cc8 to
1847b7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saturation semantics for total functions, improved angle reduction, and threshold tuning
Saturation Over Errors:
Error::Overflowvariant entirelyexp,pow2,sinh,cosh,tan) now saturate deterministicallyexp/pow2: Saturate toT::MAXfor large positive inputs, zero for large negativesinh: Saturates toT::MAXorT::MINbased on signcosh/tan: Saturate toT::MAXnear poles/overflowsin/cos Large Angle Fix:
I16F16::MAXreduced = angle - round(angle/2π) * 2πThreshold Tuning:
Documentation & Cleanup:
NormalizedLnArgand related helpers crate-private