Implement CCU Soft Review Feedback

[captainwerty]

Problem and Scope

Description

Gotchas and Limitations

Testing

• HOOTL testing
• HITL testing
• Human tested

Testing Details

Larger Impact

Additional Context and Ticket

[dchansen06]

Small change of when the debug message is printed to no longer be inside the interrupt

Please also fill in the PR description

[dchansen06]

You cannot do this inside of an interrupt (the ISR) it just takes too much time. Anything done in an ISR supercedes CAN interrupts (which are the lowest priority interrupt due to the risk of the bus flooding and nothing happening) and printing is slow and in an ISR it cannot be interrupted to capture a message or something, while outside of an ISR it can be interrupted just fine.

Instead, I want you to define a global volatile boolean and here I want you to set that flag high; then, on state tick, I want you to check the status of the flag and if it is high then I would like you to call the function to print all the things and set the flag low.

---

Something vaguely like the following perhaps

// In StateUtils.h
extern volatile bool request_print_statedata;

// In StateUtils.c
volatile bool request_print_statedata;

void CheckForDebugPrint(void)
{
    if (!request_print_statedata)
        return;

    LOGOMATIC(...)
    ...
    LOGOMATIC(...)

    request_print_statedata = false;
}

Suggested change

	VCP_StateDump(&state_data);
	request_print_statedata = true;

And then just call CheckForDebugPrint() inside of the main infinite while loop

[dchansen06]

See https://github.com/Gaucho-Racing/Firmware/pull/407/changes#r3062636999

[dchansen06]

A few code duplication problems, and a few changing 0/1 to proper false/true for boolean values

[dchansen06]

Lgtm

Pending PR description

[dchansen06]

Please fill in the PR description