Fix/test assert fail#668
Open
planetchili wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses test-only assertion failures and hangs by refactoring cross-module logging linkage to avoid heap/ABI issues, improving playback-session teardown behavior under backpressure, and tuning/adjusting tests to reduce flakiness and prevent teardown deadlocks.
Changes:
- Refactor logging bridge APIs to use raw pointers/function pointers across module boundaries and add explicit “sever bridge” behavior during teardown.
- Split playback trace-session stopping into a request/finalize model and add backpressure release to prevent output-thread hangs.
- Update ETL/backpressure-related tests to avoid indefinite waits and reduce flakiness.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| IntelPresentMon/SampleClient/LogSetup.cpp | Switches to pointer-based logging link helper. |
| IntelPresentMon/PresentMonService/MockPresentMonSession.h | Splits stop into request/finalize and adds join-pending flag. |
| IntelPresentMon/PresentMonService/MockPresentMonSession.cpp | Implements request/finalize stop flow and triggers backpressure release on stop. |
| IntelPresentMon/PresentMonService/FrameBroadcaster.h | Adds timeout-aware push warning and a helper to release backpressure across PIDs. |
| IntelPresentMon/PresentMonMiddleware/Middleware.h | Makes middleware destructor noexcept. |
| IntelPresentMon/PresentMonMiddleware/Middleware.cpp | Ensures StopTracking attempts during teardown with exception containment/logging. |
| IntelPresentMon/PresentMonMiddleware/LogSetup.h | Changes copy-channel setup API to raw pointer and adds sever-bridge function. |
| IntelPresentMon/PresentMonMiddleware/LogSetup.cpp | Implements sever-bridge behavior and tags copy driver for targeted removal. |
| IntelPresentMon/PresentMonAPI2Tests/TestProcess.h | Adds bounded wait for service exit and terminates on timeout. |
| IntelPresentMon/PresentMonAPI2Tests/Logging.cpp | Moves tests to use pointer-based logging link function. |
| IntelPresentMon/PresentMonAPI2Tests/InterimBroadcasterTests.cpp | Tunes query/window sleeps for flakiness/backpressure timing. |
| IntelPresentMon/PresentMonAPI2Tests/EtlTests.cpp | Replaces first-frame helper with bounded polling and drains backpressure ring during teardown. |
| IntelPresentMon/PresentMonAPI2Loader/Implementation.cpp | Adds optional resolution + export wrapper for pmLinkLoggingPtrs_. |
| IntelPresentMon/PresentMonAPI2/PresentMonAPI.cpp | Introduces pmLinkLoggingPtrs_, refactors linking internals, and severs copy bridge on unlink. |
| IntelPresentMon/PresentMonAPI2/Internal.h | Changes LoggingSingletons to function pointers and documents preferred ABI-safe API. |
| IntelPresentMon/Core/source/infra/LogSetup.cpp | Switches to pointer-based logging link helper. |
| IntelPresentMon/CommonUtilities/log/CopyDriver.h | Changes CopyDriver to hold a raw channel pointer. |
| IntelPresentMon/CommonUtilities/log/CopyDriver.cpp | Guards Submit/Flush against null channel pointer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing assertion fires cause by recent changes (during tests only). Tune timings on one flakey test. Fixing tests hanging in ETLTests group.